Skip to content

Conversation

@twocode
Copy link
Contributor

@twocode twocode commented Feb 27, 2022

https://singularity-data.quip.com/lYozAfUcsvXV/Bummock-as-an-indexing-storage

Everything (relational table & mv, semi-structured proto, structureless json) should be able to be indexed optionally.

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

https://singularity-data.quip.com/lYozAfUcsvXV/Bummock-as-an-indexing-storage
Everything (relational table & mv, semi-structured proto, structureless json) should be able to be indexed optionally.
@github-actions github-actions bot added the type/feature Type: New feature. label Feb 27, 2022
@wyhyhyhyh
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #573 (153ed9f) into main (5e9dbda) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #573      +/-   ##
============================================
- Coverage     72.95%   72.89%   -0.07%     
  Complexity     2683     2683              
============================================
  Files           876      880       +4     
  Lines         48994    49039      +45     
  Branches       1557     1557              
============================================
- Hits          35746    35745       -1     
- Misses        12443    12489      +46     
  Partials        805      805              
Flag Coverage Δ
java 62.54% <ø> (ø)
rust 77.25% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/storage/src/bummock/index/forward.rs 0.00% <0.00%> (ø)
rust/storage/src/bummock/index/inverted.rs 0.00% <0.00%> (ø)
rust/storage/src/bummock/iter/index_iterator.rs 0.00% <0.00%> (ø)
rust/storage/src/hummock/cf.rs 0.00% <0.00%> (ø)
rust/storage/src/hummock/mod.rs 73.41% <0.00%> (-0.43%) ⬇️
rust/storage/src/hummock/state_store.rs 0.00% <0.00%> (ø)
rust/storage/src/lib.rs 100.00% <ø> (ø)
rust/storage/src/table/simple_manager.rs 80.70% <ø> (ø)
rust/meta/src/hummock/compaction.rs 68.21% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9dbda...153ed9f. Read the comment docs.

@twocode twocode merged commit 54ff4bd into main Feb 28, 2022
@twocode twocode deleted the xiangyhu/indexing branch February 28, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants