feat(meta): collect from creating actors #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #512 +/- ##
============================================
- Coverage 72.70% 72.64% -0.06%
Complexity 2709 2709
============================================
Files 876 876
Lines 48902 48910 +8
Branches 1557 1557
============================================
- Hits 35554 35533 -21
- Misses 12537 12566 +29
Partials 811 811
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hzxa21
approved these changes
Feb 23, 2022
Collaborator
hzxa21
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Before, we swallow the conf change barrier for newly created MoM, which will makes the first message of these actors be
Chunkinstead ofBarrier. However, in #511 we assume the first message of any actors must beBarrier.This PR makes global barrier manager collect from the newly created actors of MoM as well. Also, we make
ChainExecutorpropagate the conf change barrier to init epoch for all downstream actors.Checklist
Refer to a related PR or issue link (optional)
#511