Skip to content

feat(expr): add builtin function TUMBLE_START #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 24, 2022
Merged

feat(expr): add builtin function TUMBLE_START #507

merged 4 commits into from
Feb 24, 2022

Conversation

@TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Feb 23, 2022

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

add builtin function TUMBLE_START

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Fix #140
Fix #454

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 23, 2022
@TennyZhuang
fmt
49e0243 
Signed-off-by: TennyZhuang <[email protected]>
fuyufjh
fuyufjh approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 23, 2022 •
edited
Loading

Codecov Report

Merging #507 (6243a35) into main (1b16ec6) will increase coverage by 0.00%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #507   +/-   ##
=========================================
  Coverage     72.70%   72.70%           
  Complexity     2709     2709           
=========================================
  Files           876      877    +1     
  Lines         49094    49123   +29     
  Branches       1557     1557           
=========================================
+ Hits          35695    35717   +22     
- Misses        12588    12595    +7     
  Partials        811      811
Flag Coverage Δ
java 63.41% <100.00%> (+<0.01%) ⬆️
rust 76.62% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/common/src/expr/expr_binary_nonnull.rs 84.30% <0.00%> (-2.01%) ⬇️
rust/common/src/expr/mod.rs 36.66% <0.00%> (ø)
rust/common/src/vector_op/tumble.rs 81.81% <81.81%> (ø)
...lanner/rel/serialization/RexToProtoSerializer.java 55.07% <100.00%> (+0.17%) ⬆️
...e/planner/sql/RisingWaveOverrideOperatorTable.java 100.00% <100.00%> (ø)
rust/meta/src/hummock/compaction.rs 68.87% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b16ec6...6243a35. Read the comment docs.

lmatz
lmatz reviewed Feb 23, 2022
View reviewed changes
@TennyZhuang TennyZhuang merged commit 0f3ba52 into main Feb 24, 2022
@TennyZhuang TennyZhuang deleted the feat/tumble-start branch February 24, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmatz lmatz lmatz left review comments

@fuyufjh fuyufjh fuyufjh approved these changes

@xx01cyx xx01cyx Awaiting requested review from xx01cyx

+1 more reviewer

@BowenXiao1999 BowenXiao1999 BowenXiao1999 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking issue: Support tumble window Support TUMBLE window in GROUP BY clause

5 participants

@TennyZhuang @lmatz @fuyufjh @BowenXiao1999