Skip to content

feat(ss-bench): add random seed option and optimize algorithm #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 23, 2022
Merged

feat(ss-bench): add random seed option and optimize algorithm #500

merged 17 commits into from
Feb 23, 2022

Conversation

@Sunt-ing
Copy link
Contributor

@Sunt-ing Sunt-ing commented Feb 23, 2022 •
edited
Loading

What's changed and what's your intention?

  • fix: fix random_delete
  • feat: support user-given random seed
  • refactor: optimize the algorithm for untrack_keys

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@Sunt-ing Sunt-ing requested review from lmatz and twocode February 23, 2022 06:59
@github-actions github-actions bot added the type/feature Type: New feature. label Feb 23, 2022
lmatz
lmatz approved these changes Feb 23, 2022
View reviewed changes
docs/developer/benchmark_tool/state_store.md Outdated
- `getrandom`: read N times in random order. May read a key/value many times.
- `getseq`: read N times sequentially.
- `prefixscanrandom`: prefix scan N times in random order.
- `deleterandom`: delete N keys in random order. May delete a key/value many times even it has been deleted before during this operation. If no valid key/values in the state store before this operation, randomly-generated keys would be deleted.
Copy link
Contributor

@lmatz lmatz Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“If no valid key/values in the state store before this operation, randomly-generated keys would be deleted",
you mean this would be a no-op?
A bit confused about what it means.

Copy link
Contributor Author

@Sunt-ing Sunt-ing Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Let me do some re-words.

@codecov
Copy link

codecov bot commented Feb 23, 2022 •
edited
Loading

Codecov Report

Merging #500 (50944f4) into main (4c08535) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #500      +/-   ##
============================================
- Coverage     72.76%   72.74%   -0.03%     
  Complexity     2709     2709              
============================================
  Files           872      872              
  Lines         48699    48792      +93     
  Branches       1556     1556              
============================================
+ Hits          35437    35492      +55     
- Misses        12452    12490      +38     
  Partials        810      810
Flag Coverage Δ
java 63.41% <ø> (ø)
rust 76.70% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/bench/ss_bench/main.rs 0.00% <ø> (ø)
rust/bench/ss_bench/operations/get.rs 0.00% <0.00%> (ø)
rust/bench/ss_bench/operations/mod.rs 0.00% <0.00%> (ø)
...st/bench/ss_bench/operations/prefix_scan_random.rs 0.00% <0.00%> (ø)
rust/bench/ss_bench/operations/write_batch.rs 0.00% <0.00%> (ø)
rust/bench/ss_bench/utils/workload.rs 0.00% <0.00%> (ø)
rust/stream/src/executor/dispatch.rs 81.05% <0.00%> (-3.91%) ⬇️
rust/common/src/types/mod.rs 64.60% <0.00%> (-2.55%) ⬇️
rust/common/src/expr/expr_unary.rs 60.20% <0.00%> (-1.58%) ⬇️
rust/common/src/expr/expr_ternary_bytes.rs 95.58% <0.00%> (-1.34%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c08535...50944f4. Read the comment docs.

@Sunt-ing Sunt-ing enabled auto-merge (squash) February 23, 2022 07:49
@Sunt-ing Sunt-ing merged commit 1426656 into main Feb 23, 2022
@Sunt-ing Sunt-ing deleted the sunt_seed branch February 23, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmatz lmatz lmatz approved these changes

@twocode twocode Awaiting requested review from twocode

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sunt-ing @lmatz