Skip to content

feat(bench): support various workload types #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2022
Merged

feat(bench): support various workload types #5

merged 2 commits into from
Jan 29, 2022

Conversation

@Sunt-ing
Copy link
Contributor

@Sunt-ing Sunt-ing commented Jan 29, 2022 •
edited
Loading

What's changed and what's your intention?

  • Main target: in order to implement random/sequential*write/delete/update benchmarks, support various workloads
  • Other note: in order to support next_key (used in sequential), changed the key type and value type from [char] to any [u8].

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@Sunt-ing Sunt-ing requested a review from twocode January 29, 2022 04:05
@github-actions github-actions bot added the type/feature Type: New feature. label Jan 29, 2022
@Sunt-ing Sunt-ing requested a review from lmatz January 29, 2022 04:15
lmatz
lmatz approved these changes Jan 29, 2022
View reviewed changes
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM

rust/bench/ss_bench/utils/workload.rs

batch.sort_by(|(k1, _), (k2, _)| k1.cmp(k2));
// As duplication rate is low, ignore filling data after deduplicating.
batch.dedup_by(|(k1, _), (k2, _)| k1 == k2);
Copy link
Contributor

@lmatz lmatz Jan 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a KeyGenerator in Rocksdb's db_bench, and it will generate duplicated key except for UNIQUE_RANDOM mode.

Does here intend to do the same?

Copy link
Contributor Author

@Sunt-ing Sunt-ing Jan 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, here is the ingest interface:
图片

@Sunt-ing Sunt-ing merged commit 182984c into main Jan 29, 2022
@Sunt-ing Sunt-ing deleted the sunt_workload branch January 29, 2022 04:41
@BugenZhao BugenZhao mentioned this pull request Mar 17, 2023
Closed
wenym1 pushed a commit that referenced this pull request Jun 18, 2024
@xuzhanhui401
Merge pull request #5 from xuzhanhui401/main-pacx
c94c31f 
upgrade maven dependency for pacx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmatz lmatz lmatz approved these changes

@twocode twocode Awaiting requested review from twocode

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sunt-ing @lmatz