Skip to content

feat(streaming): remove output for broadcast dispatcher #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2022
Merged

feat(streaming): remove output for broadcast dispatcher #499

merged 3 commits into from
Feb 23, 2022

Conversation

@BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Feb 23, 2022 •
edited
Loading

What's changed and what's your intention?

This PR refactors the trait definition of Output and Dispatcher, stores the actor id in the Output. So that we can remove outputs according to actor ids, then we can support dropping MV on MV based on this.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

A step of #412, #381.

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 23, 2022
fuyufjh
fuyufjh approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lmatz
lmatz approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xx01cyx
xx01cyx approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@xx01cyx xx01cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #499 (402d1a4) into main (45e3561) will decrease coverage by 0.07%.
The diff coverage is 49.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #499      +/-   ##
============================================
- Coverage     72.81%   72.74%   -0.08%     
+ Complexity     2711     2709       -2     
============================================
  Files           871      872       +1     
  Lines         48715    48720       +5     
  Branches       1556     1556              
============================================
- Hits          35474    35440      -34     
- Misses        12430    12470      +40     
+ Partials        811      810       -1
Flag Coverage Δ
java 63.41% <ø> (-0.01%) ⬇️
rust 76.71% <49.35%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/stream/src/task/stream_manager.rs 39.37% <0.00%> (-0.22%) ⬇️
rust/stream/src/executor/dispatch.rs 81.05% <47.22%> (-3.91%) ⬇️
rust/stream/src/executor/integration_tests.rs 99.21% <100.00%> (ø)
rust/meta/src/model/stream.rs 64.28% <0.00%> (-14.29%) ⬇️
rust/common/src/expr/expr_input_ref.rs 68.75% <0.00%> (-12.50%) ⬇️
rust/meta/src/barrier/info.rs 84.61% <0.00%> (-7.70%) ⬇️
rust/meta/src/stream/meta.rs 41.46% <0.00%> (-7.32%) ⬇️
...isingwave/planner/rel/streaming/RwStreamChain.java 85.71% <0.00%> (-2.86%) ⬇️
...ngwave/planner/rel/streaming/RwStreamExchange.java 86.66% <0.00%> (-2.38%) ⬇️
rust/batch/src/executor/top_n.rs 82.55% <0.00%> (-0.40%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e3561...402d1a4. Read the comment docs.

@BugenZhao BugenZhao merged commit a2f47a0 into main Feb 23, 2022
@BugenZhao BugenZhao deleted the bz/refactor-dispatcher-output branch February 23, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmatz lmatz lmatz approved these changes

@fuyufjh fuyufjh fuyufjh approved these changes

@wyhyhyhyh wyhyhyhyh Awaiting requested review from wyhyhyhyh

+1 more reviewer

@xx01cyx xx01cyx xx01cyx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BugenZhao @lmatz @fuyufjh @xx01cyx