Skip to content

feat: add meta grpc monitor in grafana dashboards #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2022
Merged

feat: add meta grpc monitor in grafana dashboards #448

merged 1 commit into from
Feb 21, 2022

Conversation

@wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Feb 21, 2022 •
edited
Loading

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
    This PR adds meta_grpc_latency in grafana dashboards, and refactor the other latency metrics(rate from 5s to 1s)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#436

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #448 (8c97e66) into main (f770a72) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #448      +/-   ##
============================================
- Coverage     72.96%   72.93%   -0.04%     
  Complexity     2711     2711              
============================================
  Files           871      872       +1     
  Lines         48622    48743     +121     
  Branches       1554     1554              
============================================
+ Hits          35479    35551      +72     
- Misses        12332    12381      +49     
  Partials        811      811
Flag Coverage Δ
java 63.43% <ø> (+<0.01%) ⬆️
rust 76.98% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/stream/src/executor/managed_state/join/mod.rs 65.78% <0.00%> (-25.12%) ⬇️
rust/meta/src/hummock/compaction.rs 68.21% <0.00%> (-0.67%) ⬇️
rust/stream/src/executor/hash_join.rs 82.19% <0.00%> (-0.08%) ⬇️
rust/sqlparser/tests/sqlparser_common.rs 98.87% <0.00%> (-0.05%) ⬇️
...eam/src/executor/managed_state/join/all_or_none.rs
...rc/executor/managed_state/join/join_entry_state.rs 83.19% <0.00%> (ø)
rust/sqlparser/tests/test_runner.rs 88.29% <0.00%> (ø)
...e/planner/rel/streaming/join/RwStreamHashJoin.java 94.54% <0.00%> (+0.10%) ⬆️
rust/stream/src/executor/merge.rs 90.90% <0.00%> (+2.27%) ⬆️
rust/stream/src/executor/debug/trace.rs 62.06% <0.00%> (+2.80%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f770a72...8c97e66. Read the comment docs.

@wcy-fdu wcy-fdu merged commit 5427cf6 into main Feb 21, 2022
@wcy-fdu wcy-fdu deleted the wcy_add_meta_grpc_monitor_in_grafana branch February 21, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zehaowei zehaowei zehaowei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wcy-fdu @zehaowei