Skip to content

feat(connector): kinesis support role arn and external id #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 24, 2022
Merged

feat(connector): kinesis support role arn and external id #435

merged 4 commits into from
Feb 24, 2022

Conversation

@tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Feb 21, 2022

Signed-off-by: tabVersion [email protected]

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
    • add AwsAssumeRole to support role and external id more info
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
    • no CI or ut is enabled for security reasons

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@tabVersion tabVersion requested a review from shanicky February 21, 2022 05:32
@github-actions github-actions bot added the type/feature Type: New feature. label Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022 •
edited
Loading

Codecov Report

Merging #435 (056e483) into main (eec8749) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #435      +/-   ##
============================================
+ Coverage     72.71%   72.77%   +0.06%     
  Complexity     2709     2709              
============================================
  Files           877      877              
  Lines         49179    49137      -42     
  Branches       1557     1557              
============================================
- Hits          35760    35759       -1     
+ Misses        12608    12567      -41     
  Partials        811      811
Flag Coverage Δ
java 63.40% <ø> (ø)
rust 76.72% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/connector/src/kinesis/config.rs 0.00% <ø> (ø)
rust/connector/src/kinesis/source/reader.rs 0.00% <ø> (ø)
rust/meta/src/hummock/compaction.rs 68.21% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec8749...056e483. Read the comment docs.

neverchanje
neverchanje reviewed Feb 23, 2022
View reviewed changes
neverchanje
neverchanje approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically lgtm

@tabVersion
support role arn
8240d93 
Signed-off-by: tabVersion <[email protected]>
@tabVersion
fix
544cd67 
Signed-off-by: tabVersion <[email protected]>
@tabVersion
remove tests & format code
6f1b66a 
Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion force-pushed the tab/kinesis-external_id branch from 7fc7fcb to 6f1b66a Compare February 24, 2022 07:49
@tabVersion tabVersion enabled auto-merge (squash) February 24, 2022 07:50
@tabVersion
fix
056e483 
Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion merged commit 91ca2aa into main Feb 24, 2022
@tabVersion tabVersion deleted the tab/kinesis-external_id branch February 24, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shanicky shanicky Awaiting requested review from shanicky

1 more reviewer

@neverchanje neverchanje neverchanje approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tabVersion @neverchanje