feat(ci): enable 3-node streaming e2e #405
Conversation
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
============================================
- Coverage 72.91% 72.91% -0.01%
Complexity 2686 2686
============================================
Files 867 867
Lines 48898 48898
Branches 1579 1579
============================================
- Hits 35655 35654 -1
- Misses 12430 12431 +1
Partials 813 813
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
LSTM |
| curl -fL -o ~/.cargo/bin/sqllogictest https://github.com/singularity-data/sqllogictest-rs/releases/download/v0.2.0/sqllogictest-linux-amd64 | ||
| # reply on #25, download release archive after new version release | ||
| # curl -fL -o ~/.cargo/bin/sqllogictest https://github.com/singularity-data/sqllogictest-rs/releases/download/v0.2.0/sqllogictest-linux-amd64 | ||
| cargo install sqllogictest --features bin --git https://github.com/singularity-data/sqllogictest-rs --rev 21357d4 |
There was a problem hiding this comment.
Consider to release this version ASAP, or it will make our e2e tests much slower.
Alternatively, cache the cargo assets for e2e as well. cc @skyzh
| ~/cargo-make/makers ci-1node | ||
| timeout 3m sqllogictest -p 4567 -d dev './e2e_test/streaming/**/*.slt' | ||
| ~/cargo-make/makers ci-3node | ||
| timeout 6m sqllogictest -p 4567 -d dev './e2e_test/streaming/**/*.slt' |
There was a problem hiding this comment.
How can this tests run slower on 3 nodes? 😢 Can we make the timeout stricter than 6m ?
| timeout 6m sqllogictest -p 4567 -d dev './e2e_test/streaming/**/*.slt' | |
| timeout 5m sqllogictest -p 4567 -d dev './e2e_test/streaming/**/*.slt' |
There was a problem hiding this comment.
6m is a try to make CI pass for the first time. Based on the recent 2 times runs 4m is enough.
What's changed and what's your intention?
Replace 1-node streaming e2e with 3-node in CI.
This PR reply on sqllogictest-rs#25.
Checklist
Refer to a related PR or issue link (optional)
#352
sqllogictest-rs#25