Add support for ignoring static convert methods with MapperIgnore #1941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend MapperIgnoreAttribute to support methods - Filter out ignored static methods during conversion discovery - Add tests for ignored static methods - Proposed fix for Issue riok#1929
latonz
requested changes
Sep 2, 2025
src/Riok.Mapperly/Descriptors/MappingBuilders/ConvertStaticMethodMappingBuilder.cs
Show resolved
Hide resolved
- Add [MapperIgnore] attribute filtering to ConvertInstanceMethodMappingBuilder - Add [MapperIgnore] attribute filtering to ParseMappingBuilder - Update test to use nameof(FromB) for better maintainability - Add test case for constructor fallback when static method is ignored Proposal to fix Issue riok#1929
latonz
requested changes
Sep 2, 2025
src/Riok.Mapperly/Descriptors/MappingBuilders/ConvertInstanceMethodMappingBuilder.cs
Show resolved
Hide resolved
latonz
requested changes
Sep 2, 2025
…th MapperIgnore - Extend MapperIgnoreAttribute to support methods - Add filtering for ignored methods in ParseMappingBuilder and ConvertInstanceMethodMappingBuilder - Add test cases for ignored parse and instance methods Proposal to fix Issue riok#1929
latonz
requested changes
Sep 3, 2025
- Add AttributeTargets.Method to MapperIgnoreAttribute - Update snapshot to include Method (order matched) - Move/adjust tests for parse and ToTarget ignore - Docs: mention methods and add ignore examples
latonz
previously approved these changes
Sep 4, 2025
latonz
requested changes
Sep 18, 2025
There was a problem hiding this comment.
Thank you for the updates, now it almost looks good to be merged. One small nitpick 🙈 And please also check the linter issues: https://github.com/riok/mapperly/actions/runs/17701857152/job/50422690421?pr=1941
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1929 by extending
MapperIgnoreto work with static conversion methods. Now one can mark specific static methods with[MapperIgnore]to prevent them from being used as conversion methods.Changes:
MapperIgnoreAttributeto support methodsConvertStaticMethodMappingBuilderto skip ignored static methodsTesting: