Make Retrying object callable and store stats #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it is useful to do a one-off retry of a function. Additionally, it is useful to be able to get stats from the retrying object - how many attempts were made, what time did the retry start.
|
any feedback? anything i can do to make this more attractive? my thinking in usefulness would be something like wrapping other things that you might want to retry like: Useful right? |
|
Sorry for the delay on vetting this. I haven't gotten around to digging in and doing some deeper regression/behavior testing with the constructor moving around to make sure everything stays scoped correctly. Exposing the stats are a great idea since they're already being tracked anyway. I plan to add this in to the next release. Thanks for the contribution, and I'll be sure to add you to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it is useful to do a one-off retry of a function.
Additionally, it is useful to be able to get stats from the retrying object - how many attempts were made, what time did the retry start.
I also altered the decorator a bit so that every call to the wrapped function is not creating a brand new Retrying object. Might not save a whole lot unless functions are called rapidly but its still less work to create it up front.
I also added a couple tests.