fix(DevTools, LogMonitor): prevent LogMonitor to render once as visible state #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
|
Thanks for the PR! I'm closing because the way monitors currently manage their state isn't composable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that LogMonitor is rendered once, because
isVisibleis set to true in the initial state.see https://github.com/gaearon/redux-devtools/blob/master/src/devTools.js#L89
In the LogMonitor the
isVisiblestate was updated, but that will only affect the second render cycle. This is an issue in case you try to create a universal/isomorphic application with the same template.I propose to fix it by updating the props optimistically. As an alternative we could do this case inside the LogMonitor. Let me know what you think 😄