Skip to content

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Apr 24, 2025

@stsewd stsewd requested a review from a team as a code owner April 24, 2025 23:32
@stsewd stsewd requested a review from ericholscher April 24, 2025 23:32
@ericholscher ericholscher requested a review from Copilot May 12, 2025 21:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new blog post announcing the migration from a legacy GitHub OAuth2 application to a modern GitHub App. The post details the benefits of GitHub Apps, what to expect during the transition, and provides guidance for existing and new users.

  • Adds a new markdown file with post metadata and content.
  • Details the reasons for the change and the expected user impact.
  • Includes appropriate external links and image credits.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but seems like it's not mentioning any specific dates or anything? We should at least note when we're planning to do this, or is this just a draft until we move forward with it?

@stsewd
Copy link
Member Author

stsewd commented May 13, 2025

Yeah, this should be posted after we actually ship the feature to all users.

@stsewd
Copy link
Member Author

stsewd commented May 28, 2025

Updated the blog post to mention the beta instead

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some suggestions.

Comment on lines 58 to 62
- If you are an existing user with your GitHub account already linked to Read the Docs,
you can start the migration process [from this page](https://readthedocs.org/accounts/migrate-to-github-app/).
- If you are a new user, you can sign up using the new GitHub App [from this page](https://readthedocs.org/accounts/githubapp/login/).
- If you are an existing user, but you don't have your GitHub account linked to Read the Docs,
you can link your GitHub account to our new GitHub App [from this page](https://readthedocs.org/accounts/githubapp/login/?process=connect).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change all these from this page links to some text more relevant in each case. They all look the same now which is confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the one referencing the migration page, not sure what to put for the other two

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@stsewd stsewd requested a review from ericholscher June 2, 2025 19:28
@stsewd stsewd changed the title Post: Welcome to our GitHub App Post: Announcing our GitHub App beta Jun 2, 2025
@stsewd stsewd moved this to Needs review in 📍Roadmap Jun 3, 2025
@stsewd stsewd self-assigned this Jun 3, 2025
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to go to me -- should update the date and ship it when we're ready for it.

@ericholscher
Copy link
Member

I didn't merge this because I'm not 100% sure on the deploy today, but if we go out with things, we should merge this 👍

@humitos
Copy link
Member

humitos commented Jun 24, 2025

Yeah, I think we can merge this after finishing the deploy and doing QA.

@ericholscher ericholscher merged commit db614a4 into main Jun 24, 2025
4 checks passed
@ericholscher ericholscher deleted the github-app branch June 24, 2025 15:07
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Jun 24, 2025
@ericholscher
Copy link
Member

It's linked in the app, so we need to merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants