[FREELDR] ArcGetFileInformation(): Set the Information->FileName, Length, and Attributes for filesystems #8420
+313
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @disean and @iLauncherDev too for review! |
HBelusca
added a commit
to HBelusca/reactos
that referenced
this pull request
Oct 9, 2025
…gth, and Attributes for filesystems (reactos#8420) Add support for all the supported filesystems: FAT/FATX, NTFS, ISO, EXT, BTRFS, as well as for files loaded via PXE. arc.h: - Add `FILEATTRIBUTES` enumeration; - Remove non-existing `CreateReadOnly` and `SupersedeReadOnly` `OPENMODE` values; add missing `CreateReadWrite`.
21db845 to
5f11296
Compare
HBelusca
added a commit
to HBelusca/reactos
that referenced
this pull request
Oct 9, 2025
…gth, and Attributes for filesystems (reactos#8420) Add support for all the supported filesystems: FAT/FATX, NTFS, ISO, EXT, BTRFS, as well as for files loaded via PXE. arc.h: - Add `FILEATTRIBUTES` enumeration; - Remove non-existing `CreateReadOnly` and `SupersedeReadOnly` `OPENMODE` values; add missing `CreateReadWrite`.
5f11296 to
ac3965d
Compare
DarkFire01
approved these changes
Oct 10, 2025
HBelusca
added a commit
to HBelusca/reactos
that referenced
this pull request
Oct 10, 2025
…gth, and Attributes for filesystems (reactos#8420) Add support for all the supported filesystems: FAT/FATX, NTFS, ISO, EXT, BTRFS, as well as for files loaded via PXE. arc.h: - Add `FILEATTRIBUTES` enumeration; - Remove non-existing `CreateReadOnly` and `SupersedeReadOnly` `OPENMODE` values; add missing `CreateReadWrite`.
ac3965d to
63e0f9d
Compare
HBelusca
added a commit
to HBelusca/reactos
that referenced
this pull request
Oct 10, 2025
…gth, and Attributes for filesystems (reactos#8420) CORE-9023 Add support for all the supported filesystems: FAT/FATX, NTFS, ISO, EXT, BTRFS, as well as for files loaded via PXE. arc.h: - Add `FILEATTRIBUTES` enumeration; - Remove non-existing `CreateReadOnly` and `SupersedeReadOnly` `OPENMODE` values; add missing `CreateReadWrite`.
63e0f9d to
dd114c7
Compare
disean
reviewed
Oct 10, 2025
HBelusca
added a commit
to HBelusca/reactos
that referenced
this pull request
Oct 12, 2025
… and Attributes for filesystems (reactos#8420) CORE-9023 Add support for all the supported filesystems: FAT/FATX, NTFS, ISO, EXT, BTRFS, as well as for files loaded via PXE. arc.h: - Add `FILEATTRIBUTES` enumeration; - Remove non-existing `CreateReadOnly` and `SupersedeReadOnly` `OPENMODE` values; add missing `CreateReadWrite`.
dd114c7 to
6f23e38
Compare
|
@disean please recheck :) |
disean
approved these changes
Oct 12, 2025
| ULONG FileNameLength; | ||
| UCHAR Attributes; | ||
| CHAR Filename[32]; | ||
| CHAR FileName[32]; |
There was a problem hiding this comment.
Suggested change
| CHAR FileName[32]; | |
| _Field_z_ CHAR FileName[32]; |
I'd suggest using an explicit annotation that FileName is a null-terminated string. Note that the spec uses a lowercase spelling style for the field.
There was a problem hiding this comment.
The spec has also some errors/inconsistencies too. One example (amongst many others) is the claim that this buffer is NULL-terminated even if it's counted. To be sure I add the NUL-terminator (as you've seen), but I have seen other code where the usage of the returned data wasn't assumed to be NUL-terminated.
(Regarding the casing of the name, it's now consistent with the "FileNameLength" field, and I based myself on debug symbols from some ARC binaries from MS / firmware. Additionally, if I were to follow them, names of other types would be slightly modified, like FILE_INFORMATION, etc.)
… and Attributes for filesystems (reactos#8420) CORE-9023 Add support for all the supported filesystems: FAT/FATX, NTFS, ISO, EXT, BTRFS, as well as for files loaded via PXE. arc.h: - Add `FILEATTRIBUTES` enumeration; - Remove non-existing `CreateReadOnly` and `SupersedeReadOnly` `OPENMODE` values; add missing `CreateReadWrite`.
6f23e38 to
feeb05e
Compare
1 task
HBelusca
added a commit
to HBelusca/reactos
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose & Proposed changes
Add support for all the supported filesystems: FAT/FATX, NTFS, ISO, EXT, BTRFS, as well as for files loaded via PXE.
arc.h:
FILEATTRIBUTESenumeration;CreateReadOnlyandSupersedeReadOnlyOPENMODEvalues; add missingCreateReadWrite.This PR depends on PR #8413 feature.