Skip to content

Conversation

@zenicja
Copy link
Contributor

@zenicja zenicja commented Oct 31, 2025

What did I do?

I added the foobar2000, podcasteasy, and twsynth icons, made a general license fix for the music category, and corrected missing and incorrect lines.

@zenicja zenicja changed the title [RAPPS-DB] Add Missing icons & strings for the Music category [RAPPS-DB] Add missing icons & strings for the Music category Oct 31, 2025
@zenicja
Copy link
Contributor Author

zenicja commented Oct 31, 2025

and I also recommend removing the license sections from all Turkish descriptions; it looks more legible if they are removed

image

@zenicja
Copy link
Contributor Author

zenicja commented Nov 1, 2025

@julenuri for review

@julenuri julenuri self-requested a review November 2, 2025 16:47
@julenuri julenuri self-assigned this Nov 2, 2025
@julenuri
Copy link
Collaborator

julenuri commented Nov 2, 2025

Bring me 24 hours, I will try to review asap.

Copy link
Collaborator

@julenuri julenuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes and I will pass your PR :D

Comment on lines -4 to +5
License = GPL
License = Proprietary
LicenseType = 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MPXPlay is open source according to the official website, but you need the permission from the original author to edit it. Sourcecode downloadable in: https://sourceforge.net/projects/mpxplay/files/Mpxplay/Mpxplay-MMC%20v3.2x/ And the code says:

This file is part of the Mpxplay - audio player. * //* The source code of Mpxplay is (C) copyright 1998-2025 by PDSoft (Attila Padar) http://mpxplay.sourceforge.net email: [email protected] **************** //* This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Please contact with the author (with me) if you want to use or modify this source.

Comment on lines -4 to +5
License = Public domain
License = Proprietary
LicenseType = 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagen According to the original official Github, the license is public domain. I wouldn't change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants