Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
392ec00
Support singleton webpacker (3 and above)
BookOfGreg Aug 31, 2017
4531b1c
Support Specific versions of webpacker in appraisal
BookOfGreg Aug 31, 2017
14865d8
Update appraisal
BookOfGreg Aug 31, 2017
80c03d8
Simplify
BookOfGreg Aug 31, 2017
8c7dcd8
Pin to 3 or greater
BookOfGreg Aug 31, 2017
cd74273
Compatibility for Webpacker new
BookOfGreg Aug 31, 2017
2b7cf68
Reference correct constant
BookOfGreg Sep 1, 2017
d1e665e
Fixes #778
BookOfGreg Sep 5, 2017
ea8810e
Handle manifest load
BookOfGreg Sep 5, 2017
5a78e5d
WIP, trying to get webpacker3 config with webpacker1 and 2
BookOfGreg Sep 5, 2017
b960b9a
Extract out data
BookOfGreg Sep 5, 2017
cc8528f
Ruby 2.1 doesnt support twiddledocs
BookOfGreg Sep 5, 2017
54f95b7
Take on the configuration comment, also reduce the react regex as the…
BookOfGreg Sep 8, 2017
ed8a891
Split out dummy apps for the asset pipelines.
BookOfGreg Sep 8, 2017
488a840
Split out Webpacker dummy and sprockets dummy, then change to that di…
BookOfGreg Sep 8, 2017
2c8ec5e
ignore ruby 2.1 with Rails 5
BookOfGreg Sep 8, 2017
29c1d02
Add new dummy webpacker3 app
BookOfGreg Sep 8, 2017
ca48da9
Typo in appraisal gemfile name
BookOfGreg Sep 8, 2017
41b633f
Typo in appraisal gemfile name
BookOfGreg Sep 8, 2017
a5f3da5
Pin webpacker 1.1
BookOfGreg Sep 8, 2017
9b7af66
Set directory based on gem version
BookOfGreg Sep 8, 2017
2492053
Define methods based on which webpacker version is loaded to make con…
BookOfGreg Sep 11, 2017
f33976a
Update appraisals for each version of webpacker
BookOfGreg Sep 11, 2017
1b210b0
Each one seems to need turbolinks
BookOfGreg Sep 11, 2017
72285ce
Shouldnt need turbolinks
BookOfGreg Sep 11, 2017
8c88a3b
Turns out _no_sprockets_ name is actually executable code...
BookOfGreg Sep 11, 2017
4fad8b3
Reinitialize webpacker with default config except for the following d…
BookOfGreg Sep 11, 2017
c587945
Add new Webpacker 2 folder
BookOfGreg Sep 11, 2017
b6dc2aa
Regenerate webpacker configs for webpacker 2
BookOfGreg Sep 11, 2017
7b1b5ad
Tweaking configs and requires to sensible version
BookOfGreg Sep 11, 2017
6324185
Use local node_module
BookOfGreg Sep 11, 2017
77536cd
Dont test Rails 5 on ruby 2.1
BookOfGreg Sep 11, 2017
253ccde
Make it use localhost rather than 0.0.0.0, also React 15.4 so I do no…
BookOfGreg Sep 11, 2017
2805d9d
Add Webpacker 3 test app
BookOfGreg Sep 11, 2017
9390b09
Webpack 3 settings
BookOfGreg Sep 11, 2017
4aa297f
Tweak dev-server detector
BookOfGreg Sep 12, 2017
f15b255
Use Webpackers native dev_server detection
BookOfGreg Sep 12, 2017
c61f74d
properly scope config access
BookOfGreg Sep 12, 2017
0c0b9bc
Remove require pry references
BookOfGreg Sep 12, 2017
e3efcb8
Introduce rubocop to project
BookOfGreg Sep 15, 2017
0f75fe7
rubocop --only Layout/SpaceInsideHashLiteralBraces -a
BookOfGreg Sep 15, 2017
07afcb7
rubocop --only Style/StringLiterals -a
BookOfGreg Sep 15, 2017
384a406
Test scanned the file for specific quotes.
BookOfGreg Sep 18, 2017
579367f
rubocop --only Layout/SpaceInsideBlockBraces -a
BookOfGreg Sep 18, 2017
940f5dd
rubocop --only Style/NegatedIf -a
BookOfGreg Sep 18, 2017
9437671
rubocop --only Style/TrailingCommaInLiteral -a
BookOfGreg Sep 18, 2017
caf0827
rubocop --only Layout/SpaceInsideBrackets -a
BookOfGreg Sep 18, 2017
f2330d9
rubocop --only Layout/SpaceBeforeComment -a
BookOfGreg Sep 18, 2017
e5bbe14
rubocop --only Style/ParallelAssignment -a
BookOfGreg Sep 18, 2017
83fbdaf
rubocop --only Layout/EmptyLines -a
BookOfGreg Sep 18, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Extract out data
  • Loading branch information
BookOfGreg committed Sep 5, 2017
commit b960b9a2c36fd928ea233626fbc5a19adafee508
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ class WebpackerManifestContainerTest < ActiveSupport::TestCase
end

def test_it_loads_JS_from_the_webpacker_container
binding.pry
WebpackerHelpers.compile
container = React::ServerRendering::WebpackerManifestContainer.new
js_file = container.find_asset("application.js")
Expand Down
11 changes: 9 additions & 2 deletions test/support/webpacker_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,14 @@ def manifest
end
end

def manifest_data
if Webpacker.respond_to?(:manifest)
Webpacker.manifest.refresh
else
Webpacker::Manifest.data
end
end

# Start a webpack-dev-server
# Call the block
# Make sure to clean up the server
Expand All @@ -75,8 +83,7 @@ def with_dev_server
begin
# Make sure that the manifest has been updated:
manifest_lookup("./test/dummy/public/packs/manifest.json")
webpack_manifest = manifest.data
example_asset_path = webpack_manifest.values.first
example_asset_path = manifest_data.values.first
if example_asset_path.nil?
# Debug helper
# puts "Manifest is blank, all manifests:"
Expand Down