feat: remove properties dictionary #1741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
- Coverage 87.73% 83.89% -3.85%
==========================================
Files 33 36 +3
Lines 2348 2440 +92
Branches 294 329 +35
==========================================
- Hits 2060 2047 -13
- Misses 208 309 +101
- Partials 80 84 +4 ☔ View full report in Codecov by Sentry. |
Member
|
@TimothyMakkison I guess it's a knock on effect, conflict strikes again |
901d063 to
bbaaaa9
Compare
Contributor
Author
|
Serves me right, I should've been more patient 😅 Had some very broken rebases but the resulting commit looks okay 👍 |
ChrisPulman
approved these changes
Jun 27, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OptionsandPropertiesboth internally use dictionaries sopropertiesToAddisn't neededPropertyParameterMapcontains the key and setsisParameterMappedToRequestto be true.AddPropertiesToRequestiterates the parameter indices, adding them toOptions/Propertiesif they are inAddPropertiesToRequestSmall memory saving of 72 bytes, the size of an empty
Dictionary. These benefits are much greater when a property is used.Original
Changes