feat: refactor, invert ifs, use optimal methods #1713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1713 +/- ##
==========================================
- Coverage 87.73% 86.50% -1.23%
==========================================
Files 33 34 +1
Lines 2348 2068 -280
Branches 294 295 +1
==========================================
- Hits 2060 1789 -271
+ Misses 208 201 -7
+ Partials 80 78 -2 ☔ View full report in Codecov by Sentry. |
ChrisPulman
approved these changes
Jun 10, 2024
Member
|
Thank you @TimothyMakkison |
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TryGetValueToArrayReverts changes made in feat: custom query key formatters #1570
I can't guarantee that I've caught everything. Future PR needs to rerun csharpier