Update Variant Edit form #2893
Merged
Update Variant Edit form #2893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kieckhafer is this ready for another review? |
|
@spencern still working on the price is required toast, but I think everything else is ready to go |
…merce/reaction into ek-updateVariantForm
spencern
approved these changes
Sep 29, 2017
|
Fix for the Title bug is now detailed in #2985 |
This was referenced Sep 29, 2017
Closed
Merged
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates to the Admin panel of the PDP page to enhance editing of product variants.
Compare at price(MSRP) UI to variant optionshelpTextto all form fields in the variant formhelpModeto the aforementioned help text. As of now, nothing changes with how anything is displayed, but laying the foundation for globally toggled help text in the future. (https://github.com/reactioncommerce/reaction/pull/2893/files#diff-bee363c8fbac612bc278e9c9ced881c3R33)