Skip to content

Fix translation issues in PDP #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 18, 2017
Merged

Fix translation issues in PDP #2680

merged 13 commits into from
Aug 18, 2017

Conversation

@desaawa
Copy link
Contributor

@desaawa desaawa commented Aug 15, 2017 •
edited
Loading

Resolves #2676

I had to manually update the non-English translations from master. This should work now on marketplace

Steps to test

  1. Login as admin on marketplace branch
  2. Select product and go to the PDP
  3. Switch your language to German
  4. Click on the option edit icon to open the side panel
  5. Observe that fields here are translated.
  6. Switch to any other language and observe that side panel fields are appropriately translated

@desaawa desaawa changed the title [WIP] Fix translation issues in PDP Fix translation issues in PDP Aug 16, 2017
@desaawa desaawa requested a review from brent-hoover August 16, 2017 17:30
@desaawa desaawa mentioned this pull request Aug 16, 2017
Closed
Brent Hoover and others added 3 commits August 16, 2017 22:55
LingoHub Update 🚀
4c04cc5 
Manual push by LingoHub User: Brent Hoover.
Project: reaction

Made with ❤️ by https://lingohub.com
@brent-hoover
Revert "LingoHub Update 🚀"
8244c0a 
This reverts commit 4c04cc5.
@brent-hoover
Merge branch 'marketplace' into awa-fix-translation-issues
06e863b
@brent-hoover
Copy link
Collaborator

brent-hoover commented Aug 16, 2017

@awadesmoline How am I able to test this if there are no non-English translations? These translations definitely existed at some point since they are on master?

@desaawa
Copy link
Contributor Author

desaawa commented Aug 17, 2017

I didn’t add the non-English translations because I thought the lingohub service would update them.
I will try and update all of them with the translations from master and test.

@brent-hoover
Copy link
Collaborator

brent-hoover commented Aug 18, 2017

This one isn't translated on master either but let's go ahead and add the key while we're here?

basic_reaction_product

brent-hoover
brent-hoover requested changes Aug 18, 2017
View reviewed changes
Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just add the "Drop file to Upload" key and then we're good to go

@desaawa
Copy link
Contributor Author

desaawa commented Aug 18, 2017

@zenweasel I have added and Fixed the English key for "Drop file to Upload". tested it with dummy translations for non-English languages and it worked. With LingoHub update, it should translate to other languages.

@brent-hoover brent-hoover merged commit 185de11 into marketplace Aug 18, 2017
@brent-hoover brent-hoover deleted the awa-fix-translation-issues branch August 18, 2017 10:00
@spencern spencern mentioned this pull request Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brent-hoover brent-hoover brent-hoover approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@desaawa @brent-hoover