[WIP] Media subscription performance improvements #2012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch the exact media for the desired product in the publication to save from having to get it from the Media collection later.
- Further removes the need to access the media collection from the client - Fixes most issues related to reactivity when updating media for a product - Moves some logic for updating media metadata to server
# Conflicts: # server/publications/collections/products.js
# Conflicts: # server/publications/collections/products.js
Member
Author
|
closing in favor of the simpler approach in #2073 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1815
Fetch the exact media for the desired product in the publication to
save from having to get it from the Media collection later.