Skip to content

fix: update surcharge mutation will send the whole item #6569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sushmitha-malae wants to merge 11 commits into from
Closed

fix: update surcharge mutation will send the whole item #6569

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
473f399
fix: update surcharge mutation will send the whole item
Oct 18, 2022
85694d8
Merge branch 'trunk' into fix-updateSurcharge
brent-hoover Oct 18, 2022
04e7e5c
fix: add logger to debug utc
Oct 19, 2022
663b623
Merge branch 'fix-updateSurcharge' of https://github.com/sushmitha-ma…
Oct 19, 2022
3751eca
fix: using update and find functions
Oct 19, 2022
617ff07
fix: add createdAt in the input
Oct 19, 2022
9d6b5a6
fix: add logs
Oct 19, 2022
f054ad4
Revert "fix: add logs"
Oct 19, 2022
96643a8
fix: change to find and update
Oct 19, 2022
136a54a
fix: failing unit test
Oct 19, 2022
135c54e
fix: remove the loggers
sushmitha-malae Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: using update and find functions
  • Loading branch information
m_sushmitha committed Oct 19, 2022
commit 3751ecac6c550acecdf8dc67593748cb538b4a11
17 changes: 8 additions & 9 deletions packages/api-plugin-surcharges/src/mutations/updateSurcharge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,12 @@ export default async function updateSurchargeMutation(context, input) {

Surcharge.validate(modifier, { modifier: true });

const { modifiedCount, value: updatedSurcharge } = await Surcharges.findOneAndUpdate({
_id: surchargeId,
shopId
}, modifier, {
returnOriginal: false
});
if (modifiedCount === 0 || !updatedSurcharge) throw new ReactionError("not-found", "Unable to update surcharge");

return { updatedSurcharge };
const { matchedCount } = await Surcharges.updateOne({
_id: surchargeId, shopId
}, modifier);
if (matchedCount === 0) throw new ReactionError("not-found", "Unable to update surcharge");

const updatedSurcharge = await Surcharges.findOne({ _id: surchargeId, shopId });

return updatedSurcharge;
}
12 changes: 7 additions & 5 deletions packages/api-plugin-surcharges/src/mutations/updateSurcharge.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const updatedSurcharge = {
]
};

const newSubcharge = {
const newSurcharge = {
type: "surcharge",
attributes: [
{ property: "vendor", value: "john", propertyType: "string", operator: "eq" },
Expand All @@ -51,14 +51,16 @@ const newSubcharge = {
};

test("update a surcharge", async () => {
mockContext.collections.Surcharges.findOneAndUpdate.mockReturnValueOnce(Promise.resolve({
modifiedCount: 1,
value: updatedSurcharge
mockContext.collections.Surcharges.updateOne.mockReturnValueOnce(Promise.resolve({
matchedCount: 1
}));
mockContext.collections.Surcharges.findOne.mockReturnValueOnce(Promise.resolve({
updatedSurcharge
}));

const result = await updateSurchargeMutation(mockContext, {
surchargeId: "surcharge123",
surcharge: newSubcharge,
surcharge: newSurcharge,
shopId: "shop123"
});

Expand Down