refactor: use npm package for simple-inventory plugin #6222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maria Paktiti <[email protected]>
37 tasks
kieckhafer
requested changes
Apr 21, 2020
Member
kieckhafer
left a comment
There was a problem hiding this comment.
One small change and then this is good to go.
kieckhafer
approved these changes
Apr 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6133
This PR removes the internal
simple-inventoryplugin, and installs the newapi-plugin-inventory-simplefrom npm as a replacement.The code in that npm plugin is the same, so the expected outcome of this PR is seeing nothing different than how the app currently runs.
Testing
simple-inventoryis the correct version in thesystemInformationquerySigned-off-by: Maria Paktiti [email protected]