Skip to content

Conversation

@willopez
Copy link
Member

@willopez willopez commented Oct 5, 2018

Impact: minor
Type: feature

Issue

Product tags(categories) are not currently available in the CartItem type. This missing product information prevents creation of full tracking events in the starter kit.

Solution

Add tags to the CartItem type

Testing

  1. Add an item with tags to the shopping cart
  2. In the starter kit cart page, verify that cart.items prop has a producTags property with a list of tag objects in it.

@willopez willopez requested a review from aldeed October 5, 2018 22:50
@willopez willopez added the enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug label Oct 5, 2018
@willopez willopez self-assigned this Oct 5, 2018
@willopez willopez added this to the Oxford milestone Oct 5, 2018
aldeed
aldeed previously approved these changes Oct 8, 2018
@spencern spencern changed the base branch from master to release-2.0.0-rc.5 October 8, 2018 18:40
Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GraphQL Log fix 👍

Logger.info(`GraphQL listening at ${ROOT_URL}graphql-alpha`);
Logger.info(`GraphiQL UI: ${ROOT_URL}graphiql`);
Logger.info(`GraphQL listening at ${ROOT_URL}/graphql-alpha`);
Logger.info(`GraphiQL UI: ${ROOT_URL}/graphiql`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aldeed aldeed merged commit c44d91e into release-2.0.0-rc.5 Oct 8, 2018
@aldeed aldeed deleted the feature-willopez-add-product-tags-to-cart-items branch October 8, 2018 18:45
@spencern spencern mentioned this pull request Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants