Skip to content

Conversation

@aldeed
Copy link
Contributor

@aldeed aldeed commented Aug 14, 2018

Resolves #4513
Impact: breaking
Type: feature

Changes

  • The selectFulfillmentOptionForGroup GraphQL mutation now works
  • The setShipmentMethod Meteor method now passes through to the selectFulfillmentOptionForGroup mutation

Breaking changes

  • The last argument of the setShipmentMethod Meteor method now expects just the method ID rather than the whole method object. Core client code has been updated, but you should update any custom code that calls this method.
  • Removed the resetShipmentMethod Meteor method

Testing

  1. Verify that selecting a shipment method in checkout in the Meteor app still works as before.
  2. Verify that you can use the new GraphQL mutation to select a shipment method.
mutation {
  selectFulfillmentOptionForGroup(input: {cartId: "cmVhY3Rpb24vY2FydDo1UXFTUEgzUHM1ampRejZDWQ==", cartToken: "fpRHgSW3c7mgo4rgakZwHs1LVJlBuEksgpkHIPNBS3-", fulfillmentGroupId: "cmVhY3Rpb24vZnVsZmlsbG1lbnRHcm91cDptcTV3YzVQUkNwNHJmcGNaSg==", fulfillmentMethodId: "cmVhY3Rpb24vZnVsZmlsbG1lbnRNZXRob2Q6REVXMlBxWnJQZkVOUzQ0OEE="}) {
    cart {
      checkout {
        fulfillmentGroups {
          availableFulfillmentOptions {
            price {
              displayAmount
            }
            handlingPrice {
              displayAmount
            }
            fulfillmentMethod {
              _id
              name
              displayName
            }
          }
          selectedFulfillmentOption {
            price {
              displayAmount
            }
            handlingPrice {
              displayAmount
            }
            fulfillmentMethod {
              _id
              name
              displayName
            }
          }
        }
      }
    }
  }
}

@aldeed aldeed requested a review from nnnnat August 14, 2018 19:33
@aldeed aldeed self-assigned this Aug 14, 2018
@aldeed aldeed added this to the Kit Carson milestone Aug 14, 2018
@nnnnat nnnnat changed the base branch from feat-4512-aldeed-graphql-updateFulfillmentOptionsForGroup to release-1.15.0 August 14, 2018 20:06
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nnnnat nnnnat merged commit b6ed695 into release-1.15.0 Aug 14, 2018
@nnnnat nnnnat deleted the feat-4513-aldeed-graphql-selectFulfillmentOptionForGroup branch August 14, 2018 21:29
@spencern spencern mentioned this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants