- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.2k
GraphQL: update fulfillment options for group #4538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            nnnnat
  merged 14 commits into
  release-1.15.0
from
feat-4512-aldeed-graphql-updateFulfillmentOptionsForGroup
  
      
      
   
  Aug 14, 2018 
      
    
                
     Merged
            
            GraphQL: update fulfillment options for group #4538
                    nnnnat
  merged 14 commits into
  release-1.15.0
from
feat-4512-aldeed-graphql-updateFulfillmentOptionsForGroup
  
      
      
   
  Aug 14, 2018 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    nnnnat
  
              
              approved these changes
              
                  
                    Aug 14, 2018 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
      
     Merged
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Resolves #4512
Impact: breaking
Type: feature
Changes
updateFulfillmentOptionsForGroupmutation now worksregisterFunctionis now available on the context passed to a plugin startup function.registerFunction("getShippingPrices", getShippingPrices);is now the way to register a function for getting shipping prices (quotes).Breaking changes
registerFunction("getShippingPrices", getShippingPrices);following the pattern of the included shipping rates plugin. The provided function must not depend on Meteor or cause any Meteor packages to be imported. The arguments that are provided to this function are slightly different, too. They are now(context, cart, previousQueryResults). Usecontext.collectionsto get collections for any database calls. (This pattern is subject to change.)"shipping/updateShipmentQuotes"Meteor method now passes through to theupdateFulfillmentOptionsForGroupmutation, and it takes two additional arguments (fulfillmentGroupId, cartToken). It is now called in fewer places and does not do as many adjustments of the fulfillment group object, instead assuming that they will be in the necessary state (exist, have a shipping address, have items, etc.) prior to the method being called.Testing
cartfulfillment group.