Skip to content

GraphQL: Fix CartItem.currentQuantity #4508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2018
Merged

GraphQL: Fix CartItem.currentQuantity #4508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions imports/plugins/core/graphql/server/no-meteor/resolvers/xforms/cart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,11 @@ export function decodeCartItemsOpaqueIds(items) {

/**
* @param {Object[]} catalogItems Array of CatalogItem docs from the db
* @param {Object[]} products Array of Product docs from the db
* @param {Object} cartItem CartItem
* @return {Object} Same object with GraphQL-only props added
*/
function xformCartItem(catalogItems, cartItem) {
function xformCartItem(catalogItems, products, cartItem) {
const { priceWhenAdded, productId, variantId } = cartItem;
const { currencyCode } = priceWhenAdded;

Expand All @@ -59,13 +60,15 @@ function xformCartItem(catalogItems, cartItem) {
if (!media) [media] = catalogProduct.media;
}

const variantSourceProduct = products.find((product) => product._id === variantId);

return {
...cartItem,
compareAtPrice: {
amount: variantPriceInfo.compareAtPrice,
currencyCode
},
currentQuantity: variant.quantity,
currentQuantity: variantSourceProduct && variantSourceProduct.inventoryQuantity,
imageURLs: media && media.URLs,
isBackorder: variant.isBackorder || false,
isLowQuantity: variant.isLowQuantity || false,
Expand All @@ -87,7 +90,7 @@ function xformCartItem(catalogItems, cartItem) {
* @return {Object[]} Same array with GraphQL-only props added
*/
export async function xformCartItems(collections, items) {
const { Catalog } = collections;
const { Catalog, Products } = collections;

const productIds = items.map((item) => item.productId);

Expand All @@ -100,5 +103,11 @@ export async function xformCartItems(collections, items) {
"isDeleted": { $ne: true }
}).toArray();

return items.map((item) => xformCartItem(catalogItems, item));
const products = await Products.find({
ancestors: {
$in: productIds
}
}).toArray();

return items.map((item) => xformCartItem(catalogItems, products, item));
}