(refactor): 4477 nnnnat reaction error #4494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n methods/template
… contextMenu template
…gin no-meteor server code
…gin server methods
…ror class to better match the old Meteor.Error format
…for ReactionError, updated all imports to use the alias
willopez
requested changes
Aug 2, 2018
Member
willopez
left a comment
There was a problem hiding this comment.
See comment regarding moving the error file out of the graphql folder, and conflicts need to be resolved.
| export default class ReactionError extends ExtendableError { | ||
| constructor(error, message, eventData = {}) { | ||
| super(message); | ||
| this.eventData = eventData; |
Member
There was a problem hiding this comment.
I believe @aldeed suggested that this file be moved out of the graphql directory...?
Contributor
Author
There was a problem hiding this comment.
ah, I made a copy of it and forgot to remove this one.
Contributor
Author
|
@willopez this is ready for another look |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4477
Impact: minor
Type: refactor|chore
Solution
Replaced all
Meteor.ErrorwithReactionError.Testing
docker-compose run reaction npm run test:app