Do not publish empty variant to Catalog Customer #4484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldeed
approved these changes
Aug 1, 2018
aldeed
requested changes
Aug 2, 2018
There was a problem hiding this comment.
It would be better to not put these in the catalog in the first place. We don't support selling a product that has no variants afaik.
We could throw in /imports/plugins/core/catalog/server/no-meteor/utils/publishProductToCatalog.js, or just make sure there is a minCount: 1 on the catalog schema, which is checked already. (Side note: It looks like we're catching and ignoring schema validation errors in that function, which we should not be doing.)
|
Closing in favor of #4518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4467
Impact: minor
Type: bugfix
Issue
When a Product is made visible and published without any Variant, Catalog customer gets price range as$NaN.undefined - $ -NaN.undefined
Solution
Included a condition in Products Publication to base catalog selector to not include products with empty variants. Products without any Variant does not make any sense to end customer till it is complete. Let Admin work on the product in meantime and publish as many times as needed, customer will see only when product has at least 1 variant in Catalog.
Testing
From this branch start the app, login as admin, create a product by entering title, subtitle, vendor and description only( no variant detail). Make visible and publish.
Logout as admin and see product should not be displayed on homepage.