improve PaginatedOrders query speed by rearranging pipeline #4274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The snyk-security test failed with this error: Is this something I need to fix? |
|
@zrisher thanks for this PR. The snyk failure is because this PR is coming from your fork of the project I think, and you shouldn't need to worry about that. |
|
@zrisher I'd like to get this performance improvement in the next release but it looks like you need to resolve some conflicts |
aldeed
approved these changes
Jul 19, 2018
|
One conflict here. Would love to get this merged |
brent-hoover
previously requested changes
Jul 25, 2018
c02097c to
fee9791
Compare
fee9791 to
04d723d
Compare
|
@zenweasel Rebased to latest |
|
Still LGTM |
|
@zrisher I'm still not able to fast-forward a local branch to test this locally. Could you possibly update this again? |
|
I made a new PR for this change: #4555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4271
Impact: minor
Type: performance
Issue
The query produced by
createAggregate()performs its projection before limiting the result set, and its sort can't use indices. See #4271Solution
Reorder the query.
Breaking changes
None.
Testing