Support KernelDensity in cuml.accel
#7397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need to raise `NotImplementedError` for invalid kernels, we don't need to also ensure `metric == "euclidean"`. Our implementation matches that of sklearn, and they only check the kernel not the metric.
43 tasks
csadorf
approved these changes
Oct 28, 2025
Contributor
csadorf
left a comment
There was a problem hiding this comment.
Found one bug, but otherwise LGTM.
Approving pending the tiny fix.
Co-authored-by: Simon Adorf <[email protected]>
Member
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a general cleanup of
KernelDensity, as well as exposing it throughcuml.accel.Summary:
KernelDensity.sampleto properly reflect the input type.bandwidth="scott"andbandwidth="silverman", mirroring the sklearn api.as_sklearn/from_sklearnsupport toKernelDensityKernelDensityincuml.accelFixes #7214.
Part of #7317.