Skip to content

Conversation

@jcrist
Copy link
Member

@jcrist jcrist commented Oct 8, 2025

This finishes up a few remaining tasks for cuml.neighbors in #7317. Most of the work for this was already done in #7115.

  • Simple __init__ everywhere
  • Releases the GIL for all calls to libcuml
  • Split long methods into subroutines for readability
  • Avoid unnecessary conversions in a few spots
  • General organizational cleanups for readability

@jcrist jcrist self-assigned this Oct 8, 2025
@jcrist jcrist requested a review from a team as a code owner October 8, 2025 19:48
@jcrist jcrist requested a review from dantegd October 8, 2025 19:48
@jcrist jcrist added Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 8, 2025
jcrist added 4 commits October 8, 2025 20:00
- Release GIL
- Break up long methods into subroutines
- Various cleanups and formatting fixes to improve readability
- Release GIL
- Cleanups for readability
- Release GIL
- Assorted cleanups for readability
@jcrist jcrist force-pushed the cleanup-neighbors branch from e75aa74 to 82e10e0 Compare October 9, 2025 01:01
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jcrist
Copy link
Member Author

jcrist commented Oct 10, 2025

/merge

@rapids-bot rapids-bot bot merged commit 3d0994b into rapidsai:branch-25.12 Oct 10, 2025
101 checks passed
@jcrist jcrist deleted the cleanup-neighbors branch October 10, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants