Fix HTML representation's fitted status #7146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to sync the attributes to the CPU model for the HTML repr to work properly.
jcrist
approved these changes
Aug 27, 2025
Member
jcrist
left a comment
There was a problem hiding this comment.
Seems fine to me. If we wanted a cheap optimization, only syncing something common but easy like n_features_in_ in this case would be sufficient (just enough synced to make sklearn detect the CPU model is fitted).
Alternatively we could attempt to make the _html_repr_ run on the proxy itself, but sklearn calls so many private methods defined in Base to make that work, it's not clear if reorging to run on the proxy itself would work or not cause other issues.
Anyone saving a model for use later (or accessing a fitted attribute) will require a CPU sync anyway, so not too worried about the perf.
Member
Author
|
/merge |
a577263
into
rapidsai:branch-25.10
137 of 139 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to sync the attributes to the CPU model for the HTML repr to work properly. This is because we delegate the HTML repr building to the CPU model. The advantage of this is that users get exactly what they are expecting, the downside is that we need to sync fitted attributes so that the fitted/not fitted detection works correctly. In theory we could dig into how the detection is done and only sync "that one attribute" needed to pass the test. I think that is a premature optimisation and relies on the internals of scikit-learn which means it is fragile.
closes #7145