Prevent CUDA issues when running UMAP with scikit-learn compatibility test suite #7107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice! Cool to see that this was an easy thing to fix! Could you remove |
betatim
reviewed
Aug 13, 2025
| # "check_transformers_unfitted": "UMAP does not raise error when transform called before fit", | ||
| "check_parameters_default_constructible": "UMAP parameters are mutated on init", | ||
| "check_fit_check_is_fitted": "UMAP passes check_is_fitted before being fit", | ||
| "check_estimators_empty_data_messages": "UMAP does not handle empty data", |
Member
There was a problem hiding this comment.
How much work would it be to make it so that the test passes instead of xfailing it? We already raise the right type of exception, is it "just" a question of adjusting the text to match what the check expects?
Contributor
Author
There was a problem hiding this comment.
Fixed a bench of them.
csadorf
approved these changes
Aug 28, 2025
This was referenced Sep 2, 2025
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7068