Fix DistributedDataHandler.calculate_parts_to_sizes #6737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of Dask don't like a mixture of dask and non-dask objects in `client.compute()`. Previously, `calculate_parts_to_sizes()` passed a list[tuple[str, Future]] to `client.compute()`. This updates it to only pass through the Futures.
jcrist
reviewed
May 15, 2025
jcrist
approved these changes
May 15, 2025
Contributor
Author
|
The previous failure is hopefully fixed by a change in dask / rapids-dask-dependency. Pushed an empty commit to retrigger CI now that that's in. |
Contributor
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of Dask don't like a mixture of dask and non-dask objects in
client.compute(). Previously,calculate_parts_to_sizes()passed a list[tuple[str, Future]] toclient.compute(). This updates it to only pass through the Futures.