Skip to content

Conversation

@jinsolp
Copy link
Contributor

@jinsolp jinsolp commented May 1, 2025

Migrating raft NN Descent calls to cuVS NN Descent calls in UMAP.

Signed-off-by: jinsolp <[email protected]>
@jinsolp jinsolp requested review from a team as code owners May 1, 2025 17:39
@jinsolp jinsolp requested review from bdice and teju85 May 1, 2025 17:39
@github-actions github-actions bot added Cython / Python Cython or Python issue CUDA/C++ labels May 1, 2025
@jinsolp jinsolp added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 1, 2025
@jinsolp jinsolp self-assigned this May 1, 2025
@jinsolp jinsolp mentioned this pull request May 1, 2025
5 tasks
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jinsolp, LGTM. Just one question.

@divyegala divyegala requested review from divyegala and removed request for bdice and teju85 May 5, 2025 16:57
@divyegala
Copy link
Member

This PR reduces the binary size of umap.cu from ~18 MB to ~6 MB.

@csadorf
Copy link
Contributor

csadorf commented May 7, 2025

/merge

@jcrist
Copy link
Member

jcrist commented May 7, 2025

/merge

@rapids-bot rapids-bot bot merged commit add80d8 into rapidsai:branch-25.06 May 7, 2025
91 of 92 checks passed
@jinsolp jinsolp deleted the umap-use-cuvs-nnd branch May 7, 2025 21:55
Ofek-Haim pushed a commit to Ofek-Haim/cuml that referenced this pull request May 13, 2025
Migrating raft NN Descent calls to cuVS NN Descent calls in UMAP.

Authors:
  - Jinsol Park (https://github.com/jinsolp)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - Divye Gala (https://github.com/divyegala)

URL: rapidsai#6611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants