Fix race condition in _block_gemv kernel
#6578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/merge |
Ofek-Haim
pushed a commit
to Ofek-Haim/cuml
that referenced
this pull request
May 13, 2025
The kernel, in order: 1. Starts a loop for every thread 2. Writes to shared memory using all threads, then syncs 3. Uses thread 0 to reduce in shared memory 4. Continues forward with the loop A sync was necessary between step 3 and 4 to ensure other threads don't continue and overwrite in shared memory while thread 0 is still reading and doing reductions. Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Micka (https://github.com/lowener) URL: rapidsai#6578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel, in order:
A sync was necessary between step 3 and 4 to ensure other threads don't continue and overwrite in shared memory while thread 0 is still reading and doing reductions.