Avoid private attributes on cuDF objects #6537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
approved these changes
Apr 14, 2025
Member
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
#6543) Similar in spirit to #6537 * Vendored `cudf.utils.dtypes.min_signed_type` as this function isn't necessarily a public function * Removed `CudfBuffer` reference as it was unused (and a non-public object) Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Jim Crist-Harif (https://github.com/jcrist) URL: #6543
Ofek-Haim
pushed a commit
to Ofek-Haim/cuml
that referenced
this pull request
May 13, 2025
It appears the usage of `._column` can be replace with public APIs or avoided it entirely. Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#6537
Ofek-Haim
pushed a commit
to Ofek-Haim/cuml
that referenced
this pull request
May 13, 2025
rapidsai#6543) Similar in spirit to rapidsai#6537 * Vendored `cudf.utils.dtypes.min_signed_type` as this function isn't necessarily a public function * Removed `CudfBuffer` reference as it was unused (and a non-public object) Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Jim Crist-Harif (https://github.com/jcrist) URL: rapidsai#6543
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the usage of
._columncan be replace with public APIs or avoided it entirely.