Update FIL tests to use XGBoost UBJSON instead of binary #6153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphicks
approved these changes
Dec 3, 2024
Contributor
robertmaynard
left a comment
There was a problem hiding this comment.
Any reason why we cant use xgboost>=2.1.3 ?
robertmaynard
approved these changes
Dec 3, 2024
jakirkham
requested changes
Dec 3, 2024
Member
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Hyunsu! 🙏
Had a recommendation below
jakirkham
approved these changes
Dec 3, 2024
Member
jakirkham
left a comment
There was a problem hiding this comment.
Looks good. Thanks Hyunsu! 🙏
Member
|
Checked in offline. Sounds like we are ready to merge this. Going to queue it to merge so we don't forget (as code freeze is around the corner) |
Member
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from 2.1, XGBoost uses UBJSON format to serialize models.
Replace all uses of the legacy model format with UBJSON.
Also make
xgboosta test dependency of cuML so that the FIL tests run in the CI pipelines.