Clarify -c and -q flag description #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyll
reviewed
Jan 17, 2020
hey.go
Outdated
| -c Number of workers to run concurrently. Total number of requests cannot | ||
| be smaller than the concurrency level. Default is 50. | ||
| -q Rate limit, in queries per second (QPS). Default is no rate limit. | ||
| -q Rate limit, in queries per worker per second. Default is no rate limit. |
Owner
There was a problem hiding this comment.
This is actually per request per worker per second. Is it possible to say "QPS per worker"?
rakyll
approved these changes
Jan 18, 2020
Owner
|
Thanks so much!!! |
Contributor
Author
|
I realized that the |
Owner
|
Would you be interested in sending a follow up PR to update the README? |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the description of -c to
Number of workers to run concurrently...and -q toin queries per worker per second..... This will clarify that the c flag is used to define the number of threads and -q is actually the number of requests per worker per second.Motivated by #140 #143 and #158
Use Cases:
-ctimes-q-n:-cis not the total number of requests and would set-cas 10 because the default-nis 200 so200 * 10 = 2,000 queriesThis makes more sense as a first impression, but I'm open to any recommendations!