Don't hard code number of compile threads #3856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RVM can automatically detect number of available threads.
cb02bad to
07e9950
Compare
pkuczynski
approved these changes
Dec 30, 2016
mpapis
requested changes
Dec 30, 2016
| #### Bug fixes: | ||
| * $PATH become empty after __rvm_unload executed [\#3847](https://github.com/rvm/rvm/pull/3847) | ||
| * RVM incorrectly tries to install llvm 3.5 when trying to install Rubinius 3 [\#3848](https://github.com/rvm/rvm/pull/3848), | ||
| * RVM hardcodes number of compile threads [\#3856](https://github.com/rvm/rvm/pull/3856) |
There was a problem hiding this comment.
it's more: enable automated detection of compilation cores for compiling movable(binary) rubies
There was a problem hiding this comment.
This could be rephrased indeed, but its a minor thing
| ;; | ||
| esac | ||
| rvm_configure_flags+=( --sysconfdir=/etc ) | ||
| rvm_make_flags+=( -j3 ) |
There was a problem hiding this comment.
this enables automated detection of threads to the number of available cores
There was a problem hiding this comment.
I agree with @bartoszcisek that this is obsolete and should be removed
pkuczynski
approved these changes
Dec 31, 2016
| #### Bug fixes: | ||
| * $PATH become empty after __rvm_unload executed [\#3847](https://github.com/rvm/rvm/pull/3847) | ||
| * RVM incorrectly tries to install llvm 3.5 when trying to install Rubinius 3 [\#3848](https://github.com/rvm/rvm/pull/3848), | ||
| * RVM hardcodes number of compile threads [\#3856](https://github.com/rvm/rvm/pull/3856) |
There was a problem hiding this comment.
This could be rephrased indeed, but its a minor thing
mpapis
approved these changes
Jan 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RVM can automatically detect number of available threads.
Changes proposed in this pull request:
-j3