Allow passing a shell name to avoid shell detection #5596
+24
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local device agents often run in a sandboxed environment that don't have persion to invoke `/bin/ps`. This change allows for passing the shell name as an argument to allow circumventing dynamic detection. A similar pattern is used in Homebrew.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local device agents often run in a sandboxed environment that don't have persion to invoke
/bin/ps. This change allows for passing the shell name as an argument to allow circumventing dynamic detection. A similar pattern is used in Homebrew.This is a proposal. If this approach seems good, then I think there might be a change needed for documentation and potentially the installers.
Fixes #5589.