Skip to content

verify: use PeerVerified for both server and client #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

verify: use PeerVerified for both server and client #2693

merged 1 commit into from
Oct 1, 2025

Conversation

djc
Copy link
Member

@djc djc commented Oct 1, 2025

No description provided.

@djc djc requested review from cpu and ctz October 1, 2025 10:20
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Oct 1, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10497648 10422757 -74891 (-0.71%) 1.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 49475086 49645693 170607 (0.34%) 0.76%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 49815834 49975994 160160 (0.32%) 0.67%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 49792258 49951098 158840 (0.32%) 0.78%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 49656045 49534484 -121561 (-0.24%) 0.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 49708275 49829554 121279 (0.24%) 0.64%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 41065697 41150947 85250 (0.21%) 0.50%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 42489584 42570414 80830 (0.19%) 0.47%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 42537985 42618303 80318 (0.19%) 0.43%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 49590540 49681515 90975 (0.18%) 0.47%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9053491 9037933 -15558 (-0.17%) 1.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 49512791 49595279 82488 (0.17%) 0.63%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 49778642 49856583 77941 (0.16%) 0.68%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 41205104 41144529 -60575 (-0.15%) 0.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 42454781 42515141 60360 (0.14%) 0.42%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3293826 3289510 -4316 (-0.13%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9042260 9053688 11428 (0.13%) 0.84%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3823581 3818957 -4624 (-0.12%) 0.33%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 41164715 41211623 46908 (0.11%) 0.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 49756755 49705482 -51273 (-0.10%) 0.46%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 41085483 41126703 41220 (0.10%) 0.37%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 42517883 42556757 38874 (0.09%) 0.44%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 49781879 49822960 41081 (0.08%) 0.54%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11090993 11084160 -6833 (-0.06%) 1.35%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3823194 3825501 2307 (0.06%) 0.21%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 42480576 42455113 -25463 (-0.06%) 0.30%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11113868 11107986 -5882 (-0.05%) 1.32%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 42512365 42532836 20471 (0.05%) 0.35%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2665948 2666208 260 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2438443 2438660 217 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1528855 1528987 132 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1526513 1526587 74 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3292577 3292463 -114 (-0.00%) 0.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58183295 58181385 -1910 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 49520891 49522255 1364 (0.00%) 0.69%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 49653409 49654668 1259 (0.00%) 0.80%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2435400 2435448 48 (0.00%) 0.86%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 41081046 41081772 726 (0.00%) 0.48%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2659197 2659153 -44 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 41204685 41205307 622 (0.00%) 0.55%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7216522 7216506 -16 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34734803 34734783 -20 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7214571 7214574 3 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34733087 34733094 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80358567 80358578 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46111519 46111525 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46010023 46010018 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46170832 46170837 5 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104969936 104969925 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58063466 58063460 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45901985 45901981 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80361217 80361210 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58111775 58111780 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92642403 92642396 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80234244 80234238 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80352609 80352603 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46001954 46001957 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92599041 92599035 -6 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117379762 117379769 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92642829 92642824 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92652651 92652656 5 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117327544 117327538 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80238751 80238747 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92589272 92589268 -4 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105022162 105022166 4 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57953398 57953396 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58061916 58061914 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 45999357 45999358 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46179452 46179453 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58182880 58182879 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80244903 80244902 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92588904 92588903 -1 (-0.00%) 0.20%
handshake_tickets_1.3_no_crypto_server 2062344 2062344 0 (0.00%) 0.23%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1281594 1281594 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30482966 30482966 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_client 1122227 1122227 0 (0.00%) 0.36%
handshake_session_id_ring_1.2_rsa_aes_server 3314379 3314379 0 (0.00%) 0.29%
handshake_no_resume_1.2_no_crypto_client 91187 91187 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_server 100157 100157 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58073596 58073596 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_server 73378 73378 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10954942 10954942 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30558196 30558196 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31663999 31663999 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 31869140 31869140 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31663098 31663098 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 31868052 31868052 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4849596 4849596 0 (0.00%) 0.40%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46178739 46178739 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 30562054 30562054 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2326646 2326646 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1280419 1280419 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31541809 31541809 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30448031 30448031 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_client 100967 100967 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4205656 4205656 0 (0.00%) 0.22%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3815784 3815784 0 (0.00%) 0.22%
handshake_session_id_1.3_no_crypto_server 2097361 2097361 0 (0.00%) 0.23%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30359744 30359744 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2332300 2332300 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31663277 31663277 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 3913234 3913234 0 (0.00%) 0.25%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30485965 30485965 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_server 1193362 1193362 0 (0.00%) 0.51%
handshake_session_id_1.2_no_crypto_server 1026608 1026608 0 (0.00%) 0.56%
handshake_tickets_ring_1.3_rsa_aes_server 31972100 31972100 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11110642 11110642 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_client 1207842 1207842 0 (0.00%) 0.50%
handshake_tickets_ring_1.2_rsa_aes_client 3787824 3787824 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2202150 2202150 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30451394 30451394 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 31971012 31971012 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 30489823 30489823 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 31971050 31971050 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30356381 30356381 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30455287 30455287 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11116396 11116396 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717853 1717853 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 31868090 31868090 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58192497 58192497 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_client 2212175 2212175 0 (0.00%) 0.25%
handshake_session_id_1.3_no_crypto_client 2195373 2195373 0 (0.00%) 0.25%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30555176 30555176 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3733944 3733944 0 (0.00%) 0.26%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31541087 31541087 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30363637 30363637 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 3398922 3398922 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31540908 31540908 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_1.2_no_crypto 73.48 µs 75.16 µs 1.68 µs (2.28%) 7.18%
handshake_no_resume_1.3_no_crypto 80.87 µs 82.43 µs 1.57 µs (1.94%) 5.92%
handshake_tickets_1.2_no_crypto 359.74 µs 363.63 µs 3.89 µs (1.08%) 5.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.48 ms 4.52 ms 0.04 ms (0.81%) 3.47%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.13 ms 5.16 ms 0.04 ms (0.73%) 3.69%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.17 ms 5.21 ms 0.04 ms (0.70%) 2.80%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.29 ms 5.32 ms 0.03 ms (0.65%) 2.50%
transfer_no_resume_ring_1.3_rsa_aes 5.78 ms 5.82 ms 0.04 ms (0.62%) 2.68%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 4.96 ms 4.99 ms 0.03 ms (0.60%) 3.39%
transfer_no_resume_ring_1.2_rsa_aes 5.70 ms 5.73 ms 0.03 ms (0.52%) 2.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 529.34 µs 531.99 µs 2.65 µs (0.50%) 2.19%
handshake_no_resume_ring_1.3_ecdsap256_chacha 451.84 µs 454.10 µs 2.25 µs (0.50%) 1.92%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 531.53 µs 533.86 µs 2.33 µs (0.44%) 2.14%
handshake_session_id_1.3_no_crypto 638.17 µs 635.68 µs -2.49 µs (-0.39%) 5.61%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.39 ms 8.42 ms 0.03 ms (0.39%) 1.79%
handshake_tickets_1.3_no_crypto 607.53 µs 605.46 µs -2.07 µs (-0.34%) 4.96%
handshake_no_resume_ring_1.3_ecdsap256_aes 454.92 µs 456.46 µs 1.54 µs (0.34%) 2.15%
transfer_no_resume_ring_1.3_rsa_chacha 13.34 ms 13.38 ms 0.04 ms (0.28%) 1.01%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 7.31 ms 7.33 ms 0.02 ms (0.28%) 1.47%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.59 ms 13.63 ms 0.04 ms (0.27%) 1.56%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.84 ms 12.87 ms 0.03 ms (0.26%) 1.01%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.95 ms 12.98 ms 0.03 ms (0.25%) 1.69%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.21 ms 1.22 ms 0.00 ms (0.24%) 1.00%
transfer_no_resume_1.3_no_crypto 11.70 ms 11.73 ms 0.03 ms (0.23%) 1.33%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.64 ms 13.67 ms 0.03 ms (0.22%) 1.58%
handshake_session_id_ring_1.3_ecdsap256_aes 5.40 ms 5.39 ms -0.01 ms (-0.21%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.94 ms 15.98 ms 0.03 ms (0.20%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 5.95 ms 5.93 ms -0.01 ms (-0.20%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.17 ms 1.17 ms 0.00 ms (0.20%) 4.99%
handshake_session_id_1.2_no_crypto 324.85 µs 325.48 µs 0.63 µs (0.19%) 5.79%
handshake_tickets_ring_1.3_ecdsap256_aes 5.45 ms 5.44 ms -0.01 ms (-0.19%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 945.52 µs 947.26 µs 1.74 µs (0.18%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.41 ms 5.40 ms -0.01 ms (-0.18%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 8.00 ms 8.01 ms 0.01 ms (0.18%) 1.22%
transfer_no_resume_1.2_no_crypto 11.67 ms 11.69 ms 0.02 ms (0.18%) 1.24%
handshake_no_resume_ring_1.2_rsa_aes 934.33 µs 935.97 µs 1.65 µs (0.18%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.22 ms 1.22 ms 0.00 ms (0.17%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.49 ms 8.48 ms -0.01 ms (-0.17%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 7.34 ms 7.35 ms 0.01 ms (0.17%) 1.52%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.05 ms 1.05 ms -0.00 ms (-0.17%) 6.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 7.12 ms 7.13 ms 0.01 ms (0.15%) 1.50%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.37 ms 5.36 ms -0.01 ms (-0.15%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 5.91 ms 5.90 ms -0.01 ms (-0.15%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.86 ms 5.85 ms -0.01 ms (-0.15%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 8.02 ms 8.03 ms 0.01 ms (0.15%) 1.43%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.51 ms 8.50 ms -0.01 ms (-0.15%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 7.97 ms 7.98 ms 0.01 ms (0.15%) 1.56%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.74 ms 1.74 ms -0.00 ms (-0.14%) 3.97%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 7.80 ms 7.81 ms 0.01 ms (0.14%) 1.48%
handshake_tickets_ring_1.3_ecdsap384_aes 8.54 ms 8.53 ms -0.01 ms (-0.14%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.46 ms 8.45 ms -0.01 ms (-0.13%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 5.90 ms 5.89 ms -0.01 ms (-0.13%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 7.80 ms 7.81 ms 0.01 ms (0.13%) 1.46%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 7.77 ms 7.78 ms 0.01 ms (0.13%) 1.57%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.16 ms 1.16 ms 0.00 ms (0.12%) 6.23%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.57 ms 1.57 ms -0.00 ms (-0.11%) 3.73%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 7.99 ms 8.00 ms 0.01 ms (0.11%) 1.55%
handshake_no_resume_ring_1.3_rsa_aes 942.74 µs 943.68 µs 0.94 µs (0.10%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 7.15 ms 7.16 ms 0.01 ms (0.08%) 1.81%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 7.83 ms 7.84 ms 0.00 ms (0.04%) 1.63%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.48 ms 1.48 ms 0.00 ms (0.02%) 1.57%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.55 ms 0.00 ms (0.02%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.39 ms 1.39 ms -0.00 ms (-0.01%) 1.33%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Oct 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.79%. Comparing base (0f45728) to head (d03cf23).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/verify.rs 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2693      +/-   ##
==========================================
- Coverage   94.80%   94.79%   -0.01%     
==========================================
  Files          95       95              
  Lines       21789    21784       -5     
  Branches      615      615              
==========================================
- Hits        20656    20651       -5     
  Misses       1005     1005              
  Partials      128      128

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit 6974304 Oct 1, 2025
38 of 40 checks passed
@djc djc deleted the peer-verified branch October 1, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

@cpu cpu Awaiting requested review from cpu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djc @ctz