Skip to content

Include MLKEM in bogo tests of aws-lc-rs #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

Include MLKEM in bogo tests of aws-lc-rs #2564

merged 1 commit into from
Jul 16, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Jul 15, 2025

This is available by default now.

(found in review of #2550)

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jul 15, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_ring_1.2_rsa_aes_server 3785268 4068554 ⚠️ 283286 (7.48%) 0.44%
handshake_session_id_ring_1.2_rsa_aes_client 3865178 4154184 ⚠️ 289006 (7.48%) 0.35%
handshake_tickets_ring_1.2_rsa_aes_client 4254386 4543028 ⚠️ 288642 (6.78%) 0.59%
handshake_tickets_ring_1.2_rsa_aes_server 4384406 4667609 ⚠️ 283203 (6.46%) 0.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1759142 1784754 ⚠️ 25612 (1.46%) 1.33%
handshake_no_resume_ring_1.2_rsa_aes_client 2233611 2243298 ⚠️ 9687 (0.43%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4294417 4344870 50453 (1.17%) 1.20%
handshake_session_id_1.2_no_crypto_server 1027031 1022889 -4142 (-0.40%) 1.34%
handshake_tickets_1.2_no_crypto_server 1193404 1189264 -4140 (-0.35%) 1.11%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 63655715 63811587 155872 (0.24%) 0.79%
handshake_session_id_1.3_no_crypto_client 2206040 2200670 -5370 (-0.24%) 1.81%
handshake_tickets_1.3_no_crypto_client 2222652 2217282 -5370 (-0.24%) 1.80%
handshake_tickets_1.3_no_crypto_server 2059589 2054729 -4860 (-0.24%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 63556651 63706119 149468 (0.24%) 0.81%
handshake_session_id_1.3_no_crypto_server 2097763 2092873 -4890 (-0.23%) 1.01%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 63712559 63565776 -146783 (-0.23%) 0.68%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3670282 3661852 -8430 (-0.23%) 0.57%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10457441 10435871 -21570 (-0.21%) 0.93%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49133161 49217953 84792 (0.17%) 0.46%
handshake_no_resume_1.2_no_crypto_server 78292 78158 -134 (-0.17%) 0.62%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 63577624 63683193 105569 (0.17%) 0.76%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49063989 49145256 81267 (0.17%) 0.58%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4750432 4743654 -6778 (-0.14%) 0.55%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49132726 49065872 -66854 (-0.14%) 0.48%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11329112 11314498 -14614 (-0.13%) 0.90%
handshake_no_resume_1.3_no_crypto_server 101725 101595 -130 (-0.13%) 0.68%
handshake_no_resume_1.3_no_crypto_client 112067 111924 -143 (-0.13%) 1.07%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 63440722 63519163 78441 (0.12%) 0.62%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49100791 49160102 59311 (0.12%) 0.49%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9512806 9522957 10151 (0.11%) 1.05%
handshake_session_id_1.2_no_crypto_client 1133711 1134867 1156 (0.10%) 0.74%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 63641855 63581993 -59862 (-0.09%) 0.74%
handshake_no_resume_ring_1.2_rsa_aes_server 10977806 10987273 9467 (0.09%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 63363591 63315450 -48141 (-0.08%) 0.58%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4136772 4133746 -3026 (-0.07%) 0.47%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 63594630 63549064 -45566 (-0.07%) 0.52%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3746944 3744282 -2662 (-0.07%) 0.28%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3302880 3304981 2101 (0.06%) 0.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 47845634 47875877 30243 (0.06%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9525752 9531583 5831 (0.06%) 1.21%
handshake_tickets_1.2_no_crypto_client 1219551 1220288 737 (0.06%) 1.92%
handshake_no_resume_1.2_no_crypto_client 102457 102507 50 (0.05%) 0.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49134305 49111139 -23166 (-0.05%) 0.47%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 63622677 63651774 29097 (0.05%) 0.79%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 47758377 47737721 -20656 (-0.04%) 0.51%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 47911055 47891607 -19448 (-0.04%) 0.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 63462460 63437525 -24935 (-0.04%) 0.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 63583401 63598953 15552 (0.02%) 0.86%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1756476 1756886 410 (0.02%) 5.49%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 47913857 47925017 11160 (0.02%) 0.55%
transfer_no_resume_ring_1.2_rsa_aes_server 45906404 45915924 9520 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2657606 2658148 542 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31556337 31562397 6060 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31559666 31565726 6060 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31678317 31684377 6060 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31681646 31687706 6060 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31559192 31565222 6030 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 31880673 31886763 6090 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 31883372 31889462 6090 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 31983423 31989513 6090 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 31986122 31992212 6090 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31681172 31687202 6030 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 31883303 31889363 6060 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 31986053 31992113 6060 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 47804529 47795562 -8967 (-0.02%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2661300 2661789 489 (0.02%) 0.73%
transfer_no_resume_ring_1.2_rsa_aes_client 57950388 57960718 10330 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49108393 49116785 8392 (0.02%) 0.59%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4292848 4292124 -724 (-0.02%) 4.48%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11325066 11326762 1696 (0.01%) 1.15%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30355663 30360163 4500 (0.01%) 0.21%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30358696 30363196 4500 (0.01%) 0.21%
handshake_session_id_ring_1.3_rsa_chacha_client 30362820 30367320 4500 (0.01%) 0.21%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30447313 30451813 4500 (0.01%) 0.21%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30450346 30454846 4500 (0.01%) 0.21%
handshake_session_id_ring_1.3_rsa_aes_client 30454470 30458970 4500 (0.01%) 0.21%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30481593 30486093 4500 (0.01%) 0.21%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30485026 30489526 4500 (0.01%) 0.21%
handshake_tickets_ring_1.3_rsa_chacha_client 30489133 30493633 4500 (0.01%) 0.21%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30553803 30558303 4500 (0.01%) 0.21%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30557257 30561757 4500 (0.01%) 0.21%
handshake_tickets_ring_1.3_rsa_aes_client 30561364 30565864 4500 (0.01%) 0.21%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1282334 1282485 151 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1283518 1283667 149 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 47756769 47760956 4187 (0.01%) 0.74%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 63380932 63385179 4247 (0.01%) 0.90%
handshake_no_resume_ring_1.3_rsa_aes_client 2337505 2337615 110 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2343159 2343269 110 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1721705 1721626 -79 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3301627 3301703 76 (0.00%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3130855 3130922 67 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7212586 7212738 152 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3124821 3124886 65 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7214547 7214694 147 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11112456 11112607 151 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11118219 11118368 149 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34740461 34740586 125 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34742177 34742295 118 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46119390 46119452 62 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58118097 58118161 64 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104980493 104980557 64 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117362064 117362131 67 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58186428 58186436 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46010412 46010418 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80363480 80363470 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92592286 92592297 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80244028 80244037 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80352187 80352178 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46171698 46171703 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46172700 46172705 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58181240 58181246 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80352540 80352547 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46182994 46182990 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92595854 92595862 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92646589 92646596 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92585923 92585929 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80247221 80247216 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58068496 58068499 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58176486 58176489 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58059843 58059845 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92636645 92636648 3 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117405049 117405052 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46009149 46009148 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46017298 46017299 1 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105026298 105026296 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80252185 80252184 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92642680 92642681 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58066206 58066206 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_1.2_no_crypto 73.67 µs 75.94 µs 2.27 µs (3.09%) 9.08%
handshake_no_resume_1.3_no_crypto 82.38 µs 84.87 µs 2.49 µs (3.02%) 8.34%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.61 ms 0.10 ms (2.22%) 4.24%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.31 ms 0.11 ms (2.03%) 3.97%
transfer_no_resume_ring_1.3_rsa_aes 5.77 ms 5.87 ms 0.10 ms (1.81%) 3.53%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.28 ms 5.37 ms 0.09 ms (1.79%) 3.58%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 571.62 µs 581.38 µs 9.76 µs (1.71%) 2.32%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.17 ms 5.26 ms 0.08 ms (1.63%) 4.33%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 4.96 ms 5.04 ms 0.08 ms (1.63%) 4.56%
transfer_no_resume_ring_1.2_rsa_aes 5.69 ms 5.78 ms 0.09 ms (1.57%) 3.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 573.52 µs 581.86 µs 8.35 µs (1.46%) 2.49%
handshake_session_id_ring_1.2_rsa_aes 1.44 ms 1.45 ms 0.02 ms (1.26%) 1.47%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.37 ms 8.47 ms 0.10 ms (1.21%) 2.09%
handshake_tickets_ring_1.2_rsa_aes 1.53 ms 1.55 ms 0.02 ms (1.16%) 2.07%
handshake_no_resume_ring_1.3_ecdsap256_chacha 450.81 µs 455.59 µs 4.79 µs (1.06%) 2.48%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.48 ms 8.56 ms 0.09 ms (1.03%) 1.13%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.24 ms 1.23 ms -0.01 ms (-0.93%) 8.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.16 ms 9.24 ms 0.08 ms (0.92%) 1.06%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.51 ms 8.59 ms 0.08 ms (0.91%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.74 ms 1.72 ms -0.02 ms (-0.89%) 5.68%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.35 ms 8.42 ms 0.07 ms (0.86%) 1.12%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.31 ms 8.38 ms 0.07 ms (0.85%) 1.05%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 8.99 ms 9.06 ms 0.08 ms (0.83%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.06 ms -0.01 ms (-0.82%) 8.50%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.83 ms 12.94 ms 0.11 ms (0.82%) 1.67%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.20 ms 9.27 ms 0.07 ms (0.81%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.98 ms 13.08 ms 0.10 ms (0.78%) 1.46%
transfer_no_resume_ring_1.3_rsa_chacha 13.32 ms 13.43 ms 0.10 ms (0.78%) 1.36%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.23 ms 1.22 ms -0.01 ms (-0.76%) 7.20%
handshake_session_id_1.3_no_crypto 643.57 µs 648.41 µs 4.85 µs (0.75%) 4.41%
handshake_tickets_1.3_no_crypto 615.76 µs 620.38 µs 4.61 µs (0.75%) 4.19%
handshake_no_resume_ring_1.3_ecdsap256_aes 454.23 µs 457.59 µs 3.36 µs (0.74%) 2.56%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.03 ms 9.10 ms 0.07 ms (0.74%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.66 ms 13.76 ms 0.10 ms (0.71%) 1.55%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.16 ms 9.22 ms 0.06 ms (0.71%) 1.30%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.93 ms 16.04 ms 0.11 ms (0.68%) 1.39%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.65 ms 13.74 ms 0.09 ms (0.64%) 1.67%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.19 ms 9.24 ms 0.06 ms (0.62%) 1.36%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.00 ms 9.06 ms 0.05 ms (0.61%) 1.38%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.58 ms 1.57 ms -0.01 ms (-0.55%) 6.45%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.04 ms 9.09 ms 0.05 ms (0.54%) 1.32%
transfer_no_resume_1.2_no_crypto 11.78 ms 11.72 ms -0.06 ms (-0.53%) 1.93%
handshake_no_resume_ring_1.3_rsa_chacha 943.87 µs 948.50 µs 4.63 µs (0.49%) 1.02%
handshake_no_resume_ring_1.3_rsa_aes 943.79 µs 947.57 µs 3.78 µs (0.40%) 1.08%
handshake_no_resume_ring_1.2_rsa_aes 937.24 µs 940.96 µs 3.72 µs (0.40%) 1.04%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.26 ms 1.26 ms 0.00 ms (0.35%) 1.01%
handshake_session_id_1.2_no_crypto 337.46 µs 338.61 µs 1.15 µs (0.34%) 3.41%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.25 ms 1.25 ms 0.00 ms (0.33%) 1.00%
transfer_no_resume_1.3_no_crypto 11.83 ms 11.80 ms -0.03 ms (-0.29%) 3.19%
handshake_tickets_ring_1.3_ecdsap256_aes 5.44 ms 5.45 ms 0.02 ms (0.28%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.40 ms 5.42 ms 0.01 ms (0.27%) 1.00%
handshake_tickets_1.2_no_crypto 372.05 µs 371.09 µs -0.96 µs (-0.26%) 3.69%
handshake_tickets_ring_1.3_rsa_aes 5.93 ms 5.94 ms 0.01 ms (0.23%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.36 ms 5.37 ms 0.01 ms (0.22%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.39 ms 5.40 ms 0.01 ms (0.22%) 1.14%
handshake_tickets_ring_1.3_rsa_chacha 5.90 ms 5.91 ms 0.01 ms (0.19%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.85 ms 5.86 ms 0.01 ms (0.16%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms 0.01 ms (0.15%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.53 ms 8.54 ms 0.01 ms (0.15%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 5.89 ms 5.89 ms 0.01 ms (0.12%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.48 ms 8.49 ms 0.01 ms (0.12%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.50 ms 8.51 ms 0.01 ms (0.10%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.45 ms 8.46 ms 0.01 ms (0.08%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.55 ms 0.00 ms (0.07%) 1.00%

Additional information

Historical results

Checkout details:

@ctz ctz mentioned this pull request Jul 15, 2025
Merged
@ctz ctz enabled auto-merge July 15, 2025 16:15
cpu
cpu reviewed Jul 15, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a tweak for Compliance-fips-202205-TLS-[Client|Server]-MLKEM ? 🤔

Both are failing in bogo as unexpected success.

@ctz ctz disabled auto-merge July 15, 2025 16:24
@ctz
Copy link
Member Author

ctz commented Jul 15, 2025

I think this needs a tweak for Compliance-fips-202205-TLS-[Client|Server]-MLKEM ? 🤔

Both are failing in bogo as unexpected success.

Doh. I didn't try that combination locally.

@ctz
Include MLKEM in bogo tests of aws-lc-rs
c0cf37a 
This is available by default now.
@ctz ctz force-pushed the jbp-bogo-mlkem-aws-lc-rs branch from ba0165c to c0cf37a Compare July 16, 2025 06:24
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (4087866) to head (c0cf37a).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2564   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files          97       97           
  Lines       21532    21541    +9     
=======================================
+ Hits        20526    20535    +9     
  Misses       1006     1006

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz added this pull request to the merge queue Jul 16, 2025
Merged via the queue into main with commit d2e3e0c Jul 16, 2025
34 checks passed
@ctz ctz deleted the jbp-bogo-mlkem-aws-lc-rs branch July 16, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpu cpu cpu left review comments

@djc djc djc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ctz @djc @cpu