Skip to content

server: remove ClientHello constructor #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

server: remove ClientHello constructor #2270

merged 1 commit into from
Dec 11, 2024

Conversation

djc
Copy link
Member

@djc djc commented Dec 11, 2024

Slightly fewer lines of code via logging abstraction and better readability. Worth it?

cc @s-arash from reviewing #2265.

@djc djc requested review from cpu and ctz December 11, 2024 08:31
ctz
ctz approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Dec 11, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8578692 8603240 24548 (0.29%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10443791 10418400 -25391 (-0.24%) 1.40%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3871623 3865953 -5670 (-0.15%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10714316 10699099 -15217 (-0.14%) 1.05%
handshake_session_id_ring_1.2_rsa_aes_server 4231870 4226590 -5280 (-0.12%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4696410 4691100 -5310 (-0.11%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5019344 5013704 -5640 (-0.11%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10685543 10693596 8053 (0.08%) 0.92%
handshake_tickets_ring_1.2_rsa_aes_client 4487643 4489713 2070 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4205329 4207039 1710 (0.04%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4227609 4229169 1560 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3863725 3864925 1200 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27782465 27790731 8266 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27778117 27786209 8092 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27837692 27845767 8075 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27775581 27783569 7988 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27835163 27843167 8004 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27842135 27850014 7879 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28206534 28214272 7738 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28199580 28207149 7569 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28202687 28210247 7560 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28176624 28184176 7552 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28169811 28177233 7422 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28172922 28180342 7420 (0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58181849 58192281 10432 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58331791 58341611 9820 (0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58342700 58352513 9813 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58338934 58348746 9812 (0.02%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58226027 58235808 9781 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58240723 58248621 7898 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58245680 58253574 7894 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58243604 58251492 7888 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28959208 28963121 3913 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28880858 28884608 3750 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080490 3080096 -394 (-0.01%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932184 1932430 246 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925427 1925666 239 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28883435 28886850 3415 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2073548 2073793 245 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28883439 28886780 3341 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28961965 28965265 3300 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28962001 28965254 3253 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92663956 92673768 9812 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92674860 92684670 9810 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92673023 92682826 9803 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3079700 3080016 316 (0.01%) 0.26%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30412904 30415948 3044 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30370120 30373120 3000 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41965828 41961898 -3930 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41966018 41962088 -3930 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42064138 42060238 -3900 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42064328 42060428 -3900 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40270519 40274197 3678 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40567889 40571577 3688 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40273482 40277132 3650 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40277533 40281183 3650 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40571170 40574830 3660 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40575170 40578830 3660 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40176199 40179809 3610 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40493699 40497319 3620 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40179162 40182752 3590 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40183213 40186803 3590 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40496980 40500580 3600 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40500980 40504580 3600 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92706960 92714861 7901 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92704725 92712625 7900 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92710965 92718859 7894 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41484771 41481351 -3420 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41484819 41481399 -3420 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41603001 41599611 -3390 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41603049 41599659 -3390 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41962928 41959538 -3390 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1611967 1611837 -130 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1613368 1613239 -129 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42061238 42057878 -3360 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30416346 30418762 2416 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30373240 30375598 2358 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30373722 30376025 2303 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41482178 41479298 -2880 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30416386 30418476 2090 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41600408 41597558 -2850 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8607419 8607859 440 (0.01%) 0.76%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1176561 1176611 50 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2655746 2655845 99 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2661613 2661710 97 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1174350 1174317 -33 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717609 1717566 -43 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2076775 2076825 50 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7564295 7564171 -124 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292426 11292241 -185 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7566476 7566355 -121 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563485 2563512 27 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11430735 11430624 -111 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11424755 11424645 -110 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623056 3623072 16 (0.00%) 0.25%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182417 35182551 134 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180470 35180598 128 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624332 3624323 -9 (-0.00%) 0.26%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46423828 46423839 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46477539 46477529 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46464567 46464561 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467807 46467813 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487100 46487094 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641253 80641262 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661859 80661851 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540448 80540452 4 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389595 46389597 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46456936 46456934 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535652 80535649 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648886 80648884 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554935 80554934 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470691 46470691 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_ring_1.3_ecdsap384_aes 9.41 ms 9.60 ms ⚠️ 0.19 ms (2.06%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.27 ms 6.40 ms ⚠️ 0.13 ms (2.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.36 ms 9.55 ms ⚠️ 0.19 ms (2.00%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.33 ms 6.45 ms ⚠️ 0.12 ms (1.94%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.50 ms 9.68 ms ⚠️ 0.18 ms (1.89%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.44 ms 9.62 ms ⚠️ 0.18 ms (1.88%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.83 ms 6.96 ms ⚠️ 0.13 ms (1.86%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.59 ms 3.66 ms ⚠️ 0.07 ms (1.84%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.77 ms 6.89 ms ⚠️ 0.12 ms (1.83%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.35 ms 6.47 ms ⚠️ 0.12 ms (1.81%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.66 ms ⚠️ 0.07 ms (1.81%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.84 ms 6.96 ms ⚠️ 0.12 ms (1.74%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.41 ms 6.52 ms ⚠️ 0.11 ms (1.71%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.90 ms 7.02 ms ⚠️ 0.12 ms (1.68%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.24 ms 4.29 ms ⚠️ 0.05 ms (1.24%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.27 ms 4.32 ms ⚠️ 0.05 ms (1.17%) 1.17%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.43 ms 4.49 ms 0.07 ms (1.56%) 4.08%
handshake_no_resume_ring_1.3_ecdsap256_chacha 495.81 µs 503.28 µs 7.47 µs (1.51%) 2.14%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.15 ms 5.22 ms 0.07 ms (1.39%) 3.87%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.37 ms 9.50 ms 0.13 ms (1.36%) 1.98%
handshake_no_resume_ring_1.3_ecdsap256_aes 499.11 µs 505.71 µs 6.60 µs (1.32%) 2.11%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.10 ms -0.01 ms (-1.18%) 2.40%
transfer_no_resume_ring_1.3_rsa_aes 6.76 ms 6.84 ms 0.08 ms (1.16%) 2.82%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.09 ms 5.15 ms 0.06 ms (1.13%) 3.61%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.03 ms 5.09 ms 0.06 ms (1.12%) 3.95%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.95 ms 5.00 ms 0.06 ms (1.11%) 1.13%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.94 ms 4.98 ms 0.05 ms (0.96%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 453.43 µs 457.74 µs 4.31 µs (0.95%) 2.73%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.28 ms 6.34 ms 0.06 ms (0.94%) 3.07%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 4.99 ms 5.03 ms 0.05 ms (0.92%) 1.00%
transfer_no_resume_ring_1.2_rsa_aes 6.70 ms 6.76 ms 0.06 ms (0.87%) 2.66%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.92 ms 4.96 ms 0.04 ms (0.86%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.45 ms 4.49 ms 0.04 ms (0.84%) 1.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 454.69 µs 458.29 µs 3.60 µs (0.79%) 2.94%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.11 ms -0.01 ms (-0.77%) 3.49%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.48 ms 4.51 ms 0.03 ms (0.77%) 1.12%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.08 ms -0.01 ms (-0.76%) 2.25%
handshake_no_resume_ring_1.3_rsa_chacha 990.12 µs 997.46 µs 7.34 µs (0.74%) 1.05%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.03 ms 16.15 ms 0.12 ms (0.74%) 1.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.16 ms 5.20 ms 0.04 ms (0.74%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.79 ms 1.78 ms -0.01 ms (-0.67%) 1.60%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.52 ms 0.01 ms (0.67%) 1.03%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.23 ms 0.03 ms (0.59%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 990.43 µs 996.18 µs 5.75 µs (0.58%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.14 ms 5.16 ms 0.03 ms (0.54%) 1.28%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.14 ms 5.17 ms 0.03 ms (0.54%) 1.06%
transfer_no_resume_ring_1.3_rsa_chacha 13.42 ms 13.49 ms 0.07 ms (0.52%) 1.35%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.93 ms 12.99 ms 0.06 ms (0.44%) 1.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.90 ms 12.95 ms 0.05 ms (0.42%) 1.63%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.63 ms 13.68 ms 0.06 ms (0.41%) 1.39%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.60 ms 0.01 ms (0.38%) 1.31%
handshake_no_resume_ring_1.2_rsa_aes 988.94 µs 992.00 µs 3.07 µs (0.31%) 1.16%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.59 ms 13.63 ms 0.04 ms (0.29%) 1.56%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.62 ms -0.00 ms (-0.28%) 1.60%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.17 ms 1.17 ms 0.00 ms (0.07%) 1.13%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.17 ms 1.17 ms 0.00 ms (0.00%) 1.20%

Additional information

Historical results

Checkout details:

@djc djc enabled auto-merge December 11, 2024 08:40
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (bf75664) to head (236b4e6).
Report is 26 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2270      +/-   ##
==========================================
+ Coverage   94.65%   94.91%   +0.26%     
==========================================
  Files         102      104       +2     
  Lines       23917    25182    +1265     
==========================================
+ Hits        22638    23902    +1264     
- Misses       1279     1280       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc djc added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 2f74c3d Dec 11, 2024
60 checks passed
@djc djc deleted the client-hello-construction branch December 11, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctz ctz ctz approved these changes

@cpu cpu Awaiting requested review from cpu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djc @ctz