Skip to content

Update semver-compatible dependencies #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2023
Merged

Update semver-compatible dependencies #1683

merged 1 commit into from
Dec 11, 2023

Conversation

djc
Copy link
Member

@djc djc commented Dec 11, 2023

No description provided.

@djc djc requested a review from ctz December 11, 2023 10:04
@djc djc mentioned this pull request Dec 11, 2023
Closed
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Dec 11, 2023 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

There are no other instruction count differences

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_ecdsa_aes 1.28 ms 1.27 ms -0.01 ms (-1.07%) 5.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_aes 5.15 ms 5.20 ms 0.05 ms (1.01%) 5.00%
handshake_no_resume_ring_1.3_ecdsa_chacha 1.28 ms 1.27 ms -0.01 ms (-0.91%) 5.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.91 ms 5.96 ms 0.05 ms (0.85%) 5.00%
transfer_no_resume_ring_1.2_rsa_aes 7.22 ms 7.28 ms 0.06 ms (0.83%) 5.00%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.89 ms 5.94 ms 0.05 ms (0.79%) 5.00%
transfer_no_resume_ring_1.3_rsa_aes 7.32 ms 7.38 ms 0.06 ms (0.76%) 5.00%
transfer_no_resume_ring_1.3_rsa_chacha 14.04 ms 14.14 ms 0.10 ms (0.73%) 5.00%
transfer_no_resume_ring_1.3_ecdsa_chacha 14.23 ms 14.32 ms 0.09 ms (0.66%) 5.00%
handshake_tickets_ring_1.3_ecdsa_aes 7.71 ms 7.66 ms -0.05 ms (-0.66%) 5.00%
handshake_session_id_ring_1.3_ecdsa_aes 7.70 ms 7.65 ms -0.05 ms (-0.61%) 5.00%
transfer_no_resume_ring_1.3_ecdsa_aes 7.51 ms 7.56 ms 0.05 ms (0.61%) 5.00%
handshake_session_id_ring_1.3_ecdsa_chacha 7.67 ms 7.63 ms -0.04 ms (-0.50%) 5.00%
handshake_tickets_ring_1.3_ecdsa_chacha 7.67 ms 7.63 ms -0.04 ms (-0.50%) 5.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.37 ms 6.39 ms 0.03 ms (0.45%) 5.00%
handshake_tickets_ring_1.3_rsa_aes 7.58 ms 7.55 ms -0.03 ms (-0.44%) 5.00%
handshake_session_id_ring_1.3_rsa_aes 7.57 ms 7.54 ms -0.03 ms (-0.41%) 5.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_aes 657.53 µs 660.23 µs 2.69 µs (0.41%) 5.00%
handshake_session_id_aws_lc_rs_1.3_ecdsa_aes 5.56 ms 5.58 ms 0.02 ms (0.40%) 5.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_chacha 657.25 µs 659.72 µs 2.47 µs (0.38%) 5.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_chacha 13.64 ms 13.69 ms 0.05 ms (0.36%) 5.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.39 ms 14.44 ms 0.05 ms (0.34%) 5.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.40 ms 6.42 ms 0.02 ms (0.34%) 5.00%
handshake_tickets_aws_lc_rs_1.3_ecdsa_aes 5.60 ms 5.61 ms 0.02 ms (0.29%) 5.00%
handshake_tickets_ring_1.3_rsa_chacha 7.54 ms 7.52 ms -0.02 ms (-0.29%) 5.00%
handshake_session_id_ring_1.3_rsa_chacha 7.52 ms 7.50 ms -0.02 ms (-0.27%) 5.00%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.09 ms 0.00 ms (0.26%) 5.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.36 ms 6.37 ms 0.01 ms (0.22%) 5.00%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.09 ms 0.00 ms (0.22%) 5.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.25 ms 2.25 ms -0.00 ms (-0.20%) 5.00%
handshake_tickets_aws_lc_rs_1.3_ecdsa_chacha 5.58 ms 5.59 ms 0.01 ms (0.17%) 5.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.39 ms 6.40 ms 0.01 ms (0.15%) 5.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms 0.00 ms (0.11%) 5.00%
handshake_session_id_aws_lc_rs_1.3_ecdsa_chacha 5.55 ms 5.55 ms 0.01 ms (0.10%) 5.00%
handshake_tickets_ring_1.2_rsa_aes 1.79 ms 1.79 ms 0.00 ms (0.09%) 5.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.08 ms 2.08 ms -0.00 ms (-0.08%) 5.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.41 ms 0.00 ms (0.06%) 5.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.40 ms 1.40 ms 0.00 ms (0.05%) 5.00%
handshake_session_id_ring_1.2_rsa_aes 1.70 ms 1.70 ms 0.00 ms (0.03%) 5.00%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms 0.00 ms (0.00%) 5.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4074adf) 95.90% compared to head (ba88d16) 95.90%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1683   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          78       78           
  Lines       16211    16211           
=======================================
  Hits        15547    15547           
  Misses        664      664

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz enabled auto-merge December 11, 2023 10:09
@ctz ctz added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit 937a51c Dec 11, 2023
@ctz ctz deleted the update-deps branch December 11, 2023 10:18
@aochagavia aochagavia mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctz ctz ctz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djc @ctz