Error: hide subvariants of InvalidMessage #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These subvariants were incidentally making enums from `internals` part of the public API: - CertificateStatusType - KeyUpdateRequest - ECCurveType But these enums don't add much information. For instance, CertificateStatusType only has one valid value (OCSP), and all other values would be Unknown(u8). Reporting that level of detail for the unexpected response probably belongs more in a byte-by-byte protocol debugger than the workaday Error type. Also, rename UnsupportedCurve to UnsupportedCurveType to be slightly more accurate.
Codecov Report
@@ Coverage Diff @@
## main #1243 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 61 61
Lines 14216 14216
=======================================
Hits 13633 13633
Misses 583 583
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These subvariants were incidentally making enums from
internalspart of the public API:But these enums don't add much information. For instance, CertificateStatusType only has one valid value (OCSP), and all other values would be Unknown(u8). Reporting that level of detail for the unexpected response probably belongs more in a byte-by-byte protocol debugger than the workaday Error type.
Also, rename UnsupportedCurve to UnsupportedCurveType to be slightly more accurate.
Part of #920