-
Notifications
You must be signed in to change notification settings - Fork 750
Use clap macro for rustls-mio examples #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #879 +/- ##
=======================================
Coverage 95.94% 95.94%
=======================================
Files 59 59
Lines 9501 9501
=======================================
Hits 9116 9116
Misses 385 385 Continue to review full report at Codecov.
|
|
Currently blocked on clap-rs/clap#3267. |
|
It's also an issue for trust-dns (https://github.com/bluejekyll/trust-dns/pull/1616) and for Quinn. As I understand it, rustls-mio contains a bunch of integration tests that depend on these example programs. |
Even if we go by what Tokio does, which is 6 months, then 1.53 would be OK and we're very close to 1.54 being an acceptable MSRV for us now. IDK of anything in 1.53 or 1.54 that we need, but also I humbly suggest we don't bother people too much if they're just requiring 1.54.
Perhaps we should split tlsclient and tlsserver into two programs each: A demo/utility program and the test engine. It would be nice if the tests didn't have a 3rd-party command line parsing dependency at all, or ultimately even a mio dependency. That will be needed if/when we want to address the ability for Rustls to run on the web (#808), which multiple people have requested (publicly and privately). |
The reason rustls-mio exists as it does is to separate out and remove mio as dependency of the core crate (even as a dev-dependency). See #241 for background. It definitely does not stand in the way of running the core crate under wasm. |
There are (at least) two different wasm32 environments that people are interested in: wasm32-wasi and wasm32 browser, tunneled through WebSockets. I expanded on this in #808. |
I'm going to close this draft PR since it's quite out of date with |
docopt is no longer maintained. Meanwhile, structopt provides a nice way of declaratively setting up the CLI options and arguments.