Skip to content

removing webpki::Error as return type #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

removing webpki::Error as return type #858

wants to merge 4 commits into from

Conversation

Herbert-Karl
Copy link

hi,
following I propose a solution for issue #839. As I am new to Rust and the codebase of rustls, I don't have much confidence, that the change doesn't break API or introduces side effects.
I have run the existing tests and no errors were reported. I haven't fuzzed the changed codebase or did any manual testing.

ctz
ctz previously approved these changes Nov 20, 2021
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Going to hold this one for the next release, as it's a breaking API change.

@codecov-commenter
Copy link

Codecov Report

Merging #858 (a7813d1) into main (d334e5f) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   96.17%   96.16%   -0.02%     
==========================================
  Files          59       59              
  Lines        9406     9407       +1     
==========================================
  Hits         9046     9046              
- Misses        360      361       +1
Impacted Files Coverage Δ
rustls/src/anchors.rs 80.95% <66.66%> (-1.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d334e5f...a7813d1. Read the comment docs.

briansmith
briansmith requested changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@briansmith briansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I just have one suggestion.

@ctz ctz added the next-major-release breaking changes put off until next major release label Jan 22, 2022
@djc djc mentioned this pull request Jan 4, 2023
Merged
@ctz ctz mentioned this pull request Jan 25, 2023
Merged
@ctz
Copy link
Member

ctz commented Jan 25, 2023

Thanks for the contribution here -- recently we've been trying to move away from errors that aren't machine readable because they squashed the cause into a string -- see eg. #1162. This has been fixed in the progress towards that -- see a777077.

@ctz ctz closed this Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briansmith briansmith briansmith approved these changes

@ctz ctz ctz left review comments

Assignees

No one assigned

Labels

next-major-release breaking changes put off until next major release

Projects

No open projects
v0.21 release
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Herbert-Karl @codecov-commenter @ctz @briansmith