Upgrade to time v0.2 and put it behind a feature flag #782
Conversation
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
- Coverage 77.04% 76.36% -0.68%
==========================================
Files 46 46
Lines 5333 5294 -39
==========================================
- Hits 4109 4043 -66
- Misses 1224 1251 +27
Continue to review full report at Codecov.
|
| const SQLITE_DATETIME_FMT: &str = "%Y-%m-%dT%H:%M:%S.%fZ"; | ||
| const SQLITE_DATETIME_FMT_LEGACY: &str = "%Y-%m-%d %H:%M:%S:%f %Z"; | ||
| const SQLITE_DATETIME_FMT: &str = "%Y-%m-%dT%H:%M:%S.%NZ"; | ||
| const SQLITE_DATETIME_FMT_LEGACY: &str = "%Y-%m-%d %H:%M:%S:%N %z"; |
There was a problem hiding this comment.
Maybe we should drop support to SQLITE_DATETIME_FMT_LEGACY ?
There was a problem hiding this comment.
That makes sense to me, but not sure what y'all require in the way of backwards compatibility. Just let me know what makes sense!
src/types/mod.rs
Outdated
| //! | ||
| //! ```rust | ||
| //! ```ignore |
There was a problem hiding this comment.
Not tested, but it seems possible to activate feature:
https://users.rust-lang.org/t/doctests-that-require-a-non-default-feature-is-it-possible/29529/4
| @@ -91,7 +91,7 @@ bundled-full = [ | |||
| ] | |||
|
|
|||
| [dependencies] | |||
| time = "0.1.0" | |||
| time = { version = "0.2", optional = true } | |||
There was a problem hiding this comment.
Please, add this feature to bundled-full and docs.rs.
|
This seems like it causes coverage generation to fail. Apparently this is fixed in the 0.3 branch (time-rs/time#267), so maybe we'll wait on that... That or you could do the legwork to exclude |
|
@gwenn I think it would be better to have some fix for the coverage issue, even if that's just "remove it from bundled-full until time 0.3 is out". I'd rather not take this as-is... |
|
Ugh, rock and a hard place. We're only just getting the Rust ecosystem onto time v0.2—I still have a few other transitive dependencies that need to upgrade. It's too bad they've already ceased development on time v0.2. If it's alright with you folks, I'll drop it from bundled-full and leave a comment about adding it back on v0.3? |
This also removes the usage of time in the crate's top-level documentation example, as was done for the README in rusqlite#625. Fix rusqlite#653.
This is fine by me. |
|
Ok, pushed. 🤞 |
|
And it's green! |
This also removes the usage of time in the crate's top-level
documentation example, as was done for the README in #625.
Fix #653.